Merge pull request #85 from razum2um/master

Do not write duplicate sources in the Gemfile.
thoughtbot · Feb 6, 2015 · cf2bea3 · cf2bea3
2 parents d715462 + f0de312
commit cf2bea3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/appraisal/gemfile.rb b/lib/appraisal/gemfile.rb
@@ -97,7 +97,7 @@ def gemspec(options = {})
     protected
 
     def source_entry
-      @sources.map { |source| "source #{source.inspect}" }.join("\n")
+      @sources.uniq.map { |source| "source #{source.inspect}" }.join("\n")
     end
 
     def ruby_version_entry

diff --git a/spec/appraisal/gemfile_spec.rb b/spec/appraisal/gemfile_spec.rb
@@ -17,6 +17,13 @@
     expect(gemfile.to_s.strip).to eq %{source "one"\nsource "two"}
   end
 
+  it "ignores duplicate sources" do
+    gemfile = Appraisal::Gemfile.new
+    gemfile.source "one"
+    gemfile.source "one"
+    expect(gemfile.to_s.strip).to eq %{source "one"}
+  end
+
   it "preserves dependency order" do
     gemfile = Appraisal::Gemfile.new
     gemfile.gem "one"