-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit require for Set #184
Conversation
881a9e4
to
95ec8eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please 🙏 I was wondering why my gem's CI randomly broke...
@@ -1,4 +1,5 @@ | |||
require 'appraisal/dependency' | |||
require "set" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should remain consistent with single vs. double quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that at first, but the CI linting bot yield at me for that, so I changed it to double quotes.
Looking at recent changes in the repo, double quotes seems to be the new pattern.
cc: @nickcharlton would be great to get this into a 2.4.1 patch release |
Downgrading rake to 13.0.3 worked for me until we get a new release. |
Thanks for fixing this! I'm a bit swamped at the minute, but I'll have time to look properly on Friday and should be able to cut a release. |
Came here to do just this. Props to you @marcotc! |
Funny looking Friday like I thought, but thanks again. I'm going to merge this now and push out a release. |
As
rake
moved theirrequire "set"'"
statement in13.0.4
#diff-191505f9c8 today,appraisal install
started to fail with the error:This fails for any
Appraisals
file.This affects Ruby 2.4 up to 3.0, as far as I could test.
This PR adds the
require 'set'
statement to the file that references theSet
class.