Temporarily lock Rake version for Appraisal #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
added
dev/testing
ericmustin
reviewed
Jul 6, 2021
|
Feel free to merge this PR if you need it to unblock your work. |
ericmustin
approved these changes
Jul 7, 2021
|
Looks like a new release of |
|
Reported upstream: zendesk/racecar#252 . I suggested that it'd be nice if they yanked 2.3.0, but we may want to add a temporary restriction to our Ah, the joys of legacy Ruby support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appraisal missed a
require 'set'statement in their code, butrakewas bailing them out.Rake released a new version today (
13.0.4) that moves therequire 'set'to a different location, thus appraisal broke.A fix has been submitted to
appraisal: thoughtbot/appraisal#184The relevant change is in
Gemfile. Everything else is appraisal updates.