Skip to content

Address xUnit speed comparison review feedback #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Aug 17, 2026
+5 −5
Merged

Address xUnit speed comparison review feedback #6623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/speed-comparison/Tests.Benchmark/TestVersionColumn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public static void Main()
Console.WriteLine("Testing Framework Version Column:");
Console.WriteLine("---------------------------------");

var methods = new[] { "TUnit", "TUnit_AOT", "Build_TUnit", "xUnit", "Build_xUnit", "xUnit3", "xUnit3_AOT", "Build_xUnit3", "NUnit", "Build_NUnit", "MSTest", "Build_MSTest" };
string[] methods = ["TUnit", "TUnit_AOT", "Build_TUnit", "xUnit", "Build_xUnit", "xUnit3", "xUnit3_AOT", "Build_xUnit3", "NUnit", "Build_NUnit", "MSTest", "Build_MSTest"];

foreach (var method in methods)
{
Expand Down
8 changes: 4 additions & 4 deletions tools/speed-comparison/UnifiedTests/SetupTeardownTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ public class SetupTeardownTests
#endif
{
// Simulated expensive state
private byte[] _databaseConnection;
private List<string> _tempFiles;
private HttpClient _httpClient;
private StringBuilder _logBuilder;
private byte[] _databaseConnection = null!;
private List<string> _tempFiles = null!;
private HttpClient _httpClient = null!;
private StringBuilder _logBuilder = null!;

#if TUNIT
[Before(Test)]
Expand Down
Loading