Address xUnit speed comparison review feedback

[thomhurst]

Summary

• use a typed collection expression for the framework-version method list
• explicitly initialize lifecycle-owned fields with null!

Why

Follow-up to #6621. Its unresolved review feedback identified inconsistent modern C# syntax and CS8618 nullable warnings because xUnit lifecycle initialization is not visible to constructor analysis.

Impact

No runtime behavior changes. The benchmark helper follows repository style, and the xUnit 3 speed-comparison project no longer reports CS8618 for lifecycle-owned state.

Validation

• git diff --check
• dotnet build tools/speed-comparison/Tests.Benchmark/Tests.Benchmark.csproj -c Release
• dotnet build tools/speed-comparison/UnifiedTests/UnifiedTests.csproj -c Release -p:TestFramework=XUNIT3

Summary by CodeRabbit

• Refactor
  • Updated internal test and benchmark initialization syntax.
  • Suppressed initialization warnings without changing runtime behavior or public functionality.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc011514-009f-4bd1-84df-c3d62e8a2ed2

📥 Commits

Reviewing files that changed from the base of the PR and between 1589d05 and 0fc0da0.

📒 Files selected for processing (2)

• tools/speed-comparison/Tests.Benchmark/TestVersionColumn.cs
• tools/speed-comparison/UnifiedTests/SetupTeardownTests.cs

Included review availability: Your plan includes up to 3 reviews per rolling hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The change updates one local array to collection expression syntax and initializes four private reference fields with null!. No public entities changed.

Changes

Initialization updates

Layer / File(s)	Summary
Declaration cleanup tools/speed-comparison/Tests.Benchmark/TestVersionColumn.cs, tools/speed-comparison/UnifiedTests/SetupTeardownTests.cs	The local methods array uses collection expression syntax. The setup fields use null! initializers while retaining their nullable reference types.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 0fc0d

This PR makes localized syntax and nullable-initialization updates without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: campersau

Poem

A rabbit checks each field with care,
And finds neat brackets waiting there.
null! keeps warnings out of sight,
While methods gather clean and light.
Small syntax hops make code feel right.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies that the pull request implements review feedback, which matches the stated objectives and changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch agent/address-pr-6621-feedback

---

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

This PR applies modern C# collection-expression syntax to the benchmark helper and explicitly suppresses nullable initialization warnings for fields initialized by test lifecycle hooks.

• Replaces an implicitly typed array expression with a typed collection expression.
• Initializes lifecycle-owned fields with null! without changing their runtime initial values.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable runtime, build, or security defects identified.

The collection expression preserves the existing string array contents, and the null-forgiving initializers affect nullable analysis only while retaining the fields’ prior runtime initialization behavior.

Important Files Changed

Filename	Overview
tools/speed-comparison/Tests.Benchmark/TestVersionColumn.cs	Rewrites the framework-method array using equivalent typed collection-expression syntax.
tools/speed-comparison/UnifiedTests/SetupTeardownTests.cs	Suppresses CS8618 warnings for lifecycle-initialized fields without changing runtime behavior.

_{Reviews (1): Last reviewed commit: "fix(benchmarks): address xUnit review fe..." | Re-trigger Greptile}

[claude]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

• TestVersionColumn.cs: var methods = new[] {...} → string[] methods = [...] is a straightforward collection-expression modernization, consistent with the repo's LangVersion: preview / "use modern C# and .NET features" guidance.
• SetupTeardownTests.cs: adding = null! to the four lifecycle-owned fields is correct — each is unconditionally assigned in Setup() before any test method reads it, and cleared with null! again in Cleanup(). This is the standard, safe way to suppress CS8618 for fields whose real initialization happens in a test-framework lifecycle hook rather than the constructor, and matches the PR's stated intent (resolving unresolved feedback from Add xunit.v3.aot to speed comparison #6621) without changing runtime behavior.

No inline comments to add.