Skip to content

Fix mock generator not preserving nullable annotations on reference types #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 4 commits into from
Mar 26, 2026
Merged

Fix mock generator not preserving nullable annotations on reference types #5251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48021cc
Initial plan
Copilot Mar 26, 2026
a4c3722
Fix: preserve nullability of reference type parameters in mock generator
Copilot Mar 26, 2026
6287658
Address Claude's review: use Roslyn IncludeNullableReferenceTypeModif…
Copilot Mar 26, 2026
c117b61
Address review: add discoverability comment and Task<string?> test co…
Copilot Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions TUnit.Mocks.SourceGenerator.Tests/MockGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,4 +415,32 @@ void M()

return VerifyGeneratorOutput(source);
}

[Test]
public Task Interface_With_Nullable_Reference_Type_Parameters()
{
var source = """
using TUnit.Mocks;
using System.Threading.Tasks;

public interface IFoo
{
void Bar(object? baz);
string? GetValue(string? key, int count);
void Process(string nonNull, string? nullable, object? obj);
Task<string?> GetAsync(string? key);
string? NullableProp { get; set; }
}

public class TestUsage
{
void M()
{
var mock = Mock.Of<IFoo>();
}
}
""";

return VerifyGeneratorOutput(source);
}
}
Loading
Loading