Skip to content

perf: eliminate async state machine in TestCoordinator.ExecuteTestAsync #5216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Mar 22, 2026
Merged

perf: eliminate async state machine in TestCoordinator.ExecuteTestAsync #5216

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6adad36
perf: eliminate async state machine in TestCoordinator.ExecuteTestAsync
thomhurst Mar 22, 2026
8b33336
style: remove redundant Result access on successful ValueTask
thomhurst Mar 22, 2026
f1435c4
refactor: change TryStartExecutionAsync to return ValueTask, eliminat…
thomhurst Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions TUnit.Engine/Services/TestExecution/TestCoordinator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,23 @@ public TestCoordinator(
_eventReceiverOrchestrator = eventReceiverOrchestrator;
}

public async ValueTask ExecuteTestAsync(AbstractExecutableTest test, CancellationToken cancellationToken)
public ValueTask ExecuteTestAsync(AbstractExecutableTest test, CancellationToken cancellationToken)
{
await _executionGuard.TryStartExecutionAsync(test.TestId,
var task = _executionGuard.TryStartExecutionAsync(test.TestId,
() => ExecuteTestInternalAsync(test, cancellationToken));

// Fast path: avoid async state machine when the task completed synchronously
if (task.IsCompletedSuccessfully)
{
return default;
}

return AwaitAndDiscard(task);

static async ValueTask AwaitAndDiscard(ValueTask<bool> t)
{
await t.ConfigureAwait(false);
}
}

private async ValueTask ExecuteTestInternalAsync(AbstractExecutableTest test, CancellationToken cancellationToken)
Expand Down
Loading