Skip to content

perf: eliminate async state machine in TestCoordinator.ExecuteTestAsync #5216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Mar 22, 2026
Merged

perf: eliminate async state machine in TestCoordinator.ExecuteTestAsync #5216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6adad36
perf: eliminate async state machine in TestCoordinator.ExecuteTestAsync
thomhurst Mar 22, 2026
8b33336
style: remove redundant Result access on successful ValueTask
thomhurst Mar 22, 2026
f1435c4
refactor: change TryStartExecutionAsync to return ValueTask, eliminat…
thomhurst Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions TUnit.Engine/Services/TestExecution/TestCoordinator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,9 @@ public TestCoordinator(
_eventReceiverOrchestrator = eventReceiverOrchestrator;
}

public async ValueTask ExecuteTestAsync(AbstractExecutableTest test, CancellationToken cancellationToken)
{
await _executionGuard.TryStartExecutionAsync(test.TestId,
public ValueTask ExecuteTestAsync(AbstractExecutableTest test, CancellationToken cancellationToken)
=> _executionGuard.TryStartExecutionAsync(test.TestId,
() => ExecuteTestInternalAsync(test, cancellationToken));
}

private async ValueTask ExecuteTestInternalAsync(AbstractExecutableTest test, CancellationToken cancellationToken)
{
Expand Down
12 changes: 5 additions & 7 deletions TUnit.Engine/Services/TestExecution/TestExecutionGuard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,38 +10,36 @@ internal sealed class TestExecutionGuard
{
private readonly ConcurrentDictionary<string, TaskCompletionSource<bool>> _executingTests = new();

public ValueTask<bool> TryStartExecutionAsync(string testId, Func<ValueTask> executionFunc)
public ValueTask TryStartExecutionAsync(string testId, Func<ValueTask> executionFunc)
{
// Fast path: check if test is already executing without allocating a TCS
if (_executingTests.TryGetValue(testId, out var existingTcs))
{
return new ValueTask<bool>(WaitForExistingExecutionAsync(existingTcs));
return new ValueTask(WaitForExistingExecutionAsync(existingTcs));
}

var tcs = new TaskCompletionSource<bool>();
existingTcs = _executingTests.GetOrAdd(testId, tcs);

if (existingTcs != tcs)
{
return new ValueTask<bool>(WaitForExistingExecutionAsync(existingTcs));
return new ValueTask(WaitForExistingExecutionAsync(existingTcs));
}

return ExecuteAndCompleteAsync(testId, tcs, executionFunc);
}

private static async Task<bool> WaitForExistingExecutionAsync(TaskCompletionSource<bool> tcs)
private static async Task WaitForExistingExecutionAsync(TaskCompletionSource<bool> tcs)
{
await tcs.Task.ConfigureAwait(false);
return false;
}

private async ValueTask<bool> ExecuteAndCompleteAsync(string testId, TaskCompletionSource<bool> tcs, Func<ValueTask> executionFunc)
private async ValueTask ExecuteAndCompleteAsync(string testId, TaskCompletionSource<bool> tcs, Func<ValueTask> executionFunc)
{
try
{
await executionFunc().ConfigureAwait(false);
tcs.SetResult(true);
return true;
}
catch (Exception ex)
{
Expand Down
Loading