Conversation
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit.Assertions.FSharp 1.17.36 → 1.17.54
This is a Renovate Bot dependency update PR. The change is straightforward and mostly looks good, but there is one architectural concern worth flagging.
Observation: Version Skew Between TUnit Family Packages
After this PR merges, TUnit.Assertions.FSharp will be at 1.17.54 while the rest of the TUnit package family (TUnit, TUnit.Core, TUnit.Engine, TUnit.Assertions, TUnit.AspNetCore) remain at 1.17.36 in Directory.Packages.props:
<PackageVersion Include="TUnit.Assertions.FSharp" Version="1.17.54" /> <!-- updated -->
<PackageVersion Include="TUnit" Version="1.17.36" /> <!-- still old -->
<PackageVersion Include="TUnit.AspNetCore" Version="1.17.36" />
<PackageVersion Include="TUnit.Core" Version="1.17.36" />
<PackageVersion Include="TUnit.Engine" Version="1.17.36" />
<PackageVersion Include="TUnit.Assertions" Version="1.17.36" />TUnit.Assertions.FSharp wraps the core TUnit assertion engine, so a 18-patch-version gap (1.17.36 → 1.17.54) between it and its underlying dependencies could surface API compatibility issues at runtime — particularly given the release notes show a new assertion method (IsAssignableFrom<T>()) added during this window.
Since this repo is TUnit itself, these TUnit packages are the internally-developed ones — it's likely intentional that the external FSharp bindings package tracks ahead. But it's worth verifying the TUnit version constraints in TUnit.Assertions.FSharp 1.17.54's nuspec to ensure the pinned 1.17.36 versions still satisfy its dependency requirements.
Positive Notes
- All three affected files are updated consistently (central
Directory.Packages.props+ both F# template project files). - Template projects correctly pin explicit versions as expected for standalone template content.
- The update is purely additive (patch releases), reducing risk.
Overall this looks fine to merge assuming the TUnit version skew is intentional and the package dependency bounds have been verified.
2b9456d to
d486364
Compare
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit packages 1.17.36 → 1.17.54
This PR updates all TUnit family packages consistently to 1.17.54.
Previous Concern: Resolved ✓
My prior review flagged a version skew risk where TUnit.Assertions.FSharp was being updated in isolation while the rest of the TUnit family stayed at 1.17.36. This PR resolves that concern — all packages are now being updated together:
<PackageVersion Include="TUnit" Version="1.17.54" />
<PackageVersion Include="TUnit.Core" Version="1.17.54" />
<PackageVersion Include="TUnit.Engine" Version="1.17.54" />
<PackageVersion Include="TUnit.Assertions" Version="1.17.54" />
<PackageVersion Include="TUnit.AspNetCore" Version="1.17.54" />
<PackageVersion Include="TUnit.Assertions.FSharp" Version="1.17.54" />
<PackageVersion Include="TUnit.Playwright" Version="1.17.54" />Assessment
- Version consistency: All TUnit packages move in lockstep to the same version — no cross-version compatibility risk.
- Coverage is complete: Both the central
Directory.Packages.propsand all template project files (TUnit.AspNet,TUnit.AspNet.FSharp,TUnit.FSharp,TUnit.Playwright,TUnit.VB) are updated. - Patch release: Changes between 1.17.36 and 1.17.54 include doc updates, a GitHub reporter newline fix, a template redesign, and new
IsAssignableFrom<T>()/IsNotAssignableFrom<T>()assertions — all non-breaking.
This is a clean, consistent update. No concerns. ✅
d486364 to
ac883d1
Compare
Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.17.36 to 1.18.0. <details> <summary>Release notes</summary> _Sourced from [TUnit's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.18.0 <!-- Release notes generated using configuration in .github/release.yml at v1.18.0 --> ## What's Changed ### Other Changes * refactor: convert 15 manual assertions to [GenerateAssertion] by @thomhurst in thomhurst/TUnit#5029 * Fix invisible chart labels on benchmark pages by @Copilot in thomhurst/TUnit#5033 * docs: fix position of `--results-directory` in documentation by @vbreuss in thomhurst/TUnit#5038 * fix: IsEquivalentTo falls back to Equals() for types with no public members by @thomhurst in thomhurst/TUnit#5041 * perf: make test metadata creation fully synchronous by @thomhurst in thomhurst/TUnit#5045 * perf: eliminate <>c display class from generated TestSource classes by @thomhurst in thomhurst/TUnit#5047 * perf: generate per-class helper to reduce JIT compilations by ~18,000 by @thomhurst in thomhurst/TUnit#5048 * perf: consolidate per-method TestSource into per-class TestSource (~27k fewer JITs) by @thomhurst in thomhurst/TUnit#5049 * perf: eliminate per-class TestSource .ctor JITs via delegate registration by @thomhurst in thomhurst/TUnit#5051 * feat: rich HTML test reports by @thomhurst in thomhurst/TUnit#5044 ### Dependencies * chore(deps): update tunit to 1.17.54 by @thomhurst in thomhurst/TUnit#5028 * chore(deps): update dependency polyfill to 9.13.0 by @thomhurst in thomhurst/TUnit#5035 * chore(deps): update dependency polyfill to 9.13.0 by @thomhurst in thomhurst/TUnit#5036 **Full Changelog**: thomhurst/TUnit@v1.17.54...v1.18.0 ## 1.17.54 <!-- Release notes generated using configuration in .github/release.yml at v1.17.54 --> ## What's Changed ### Other Changes * docs: restructure, deduplicate, and clean up documentation by @thomhurst in thomhurst/TUnit#5019 * docs: trim, deduplicate, and restructure sidebar by @thomhurst in thomhurst/TUnit#5020 * fix: add newline to github reporter summary to fix rendering by @robertcoltheart in thomhurst/TUnit#5023 * docs: consolidate hooks, trim duplication, and restructure sidebar by @thomhurst in thomhurst/TUnit#5024 * Redesign mixed tests template by @thomhurst in thomhurst/TUnit#5026 * feat: add IsAssignableFrom<T>() and IsNotAssignableFrom<T>() assertions by @thomhurst in thomhurst/TUnit#5027 ### Dependencies * chore(deps): update tunit to 1.17.36 by @thomhurst in thomhurst/TUnit#5018 * chore(deps): update actions/upload-artifact action to v7 by @thomhurst in thomhurst/TUnit#5015 * chore(deps): update dependency microsoft.testing.extensions.codecoverage to 18.5.1 by @thomhurst in thomhurst/TUnit#5025 **Full Changelog**: thomhurst/TUnit@v1.17.36...v1.17.54 Commits viewable in [compare view](thomhurst/TUnit@v1.17.36...v1.18.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR contains the following updates:
1.17.36→1.17.541.17.36→1.17.541.17.36→1.17.541.17.36→1.17.541.17.36→1.17.541.17.36→1.17.541.17.36→1.17.54Release Notes
thomhurst/TUnit (TUnit)
v1.17.54: 1.17.54What's Changed
Other Changes
Dependencies
Full Changelog: v1.17.36...v1.17.54
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.