Skip to content

fix(assert): adjust overload resolution priorities for dictionary and set assertions #4408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
Jan 14, 2026
+18 −9
Merged

fix(assert): adjust overload resolution priorities for dictionary and set assertions #4408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd8c17d
fix(assert): adjust overload resolution priorities for dictionary and…
thomhurst Jan 14, 2026
c232bee
test: update verified API files for assertion overload resolution cha…
thomhurst Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions TUnit.Assertions.Tests/SetAssertionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
using System.Collections.Immutable;

namespace TUnit.Assertions.Tests;

/// <summary>
Expand Down Expand Up @@ -287,4 +289,11 @@ public async Task HashSet_String_Works()

await Assert.That(set).IsProperSubsetOf(superset);
}

[Test]
public async Task Set_is_empty()
{
var set = ImmutableHashSet<int>.Empty;
await Assert.That(set).IsEmpty();
}
}
6 changes: 3 additions & 3 deletions TUnit.Assertions/Extensions/Assert.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public static class Assert
/// This overload enables better type inference for dictionary operations like ContainsKey.
/// Example: await Assert.That(dict).ContainsKey("key");
/// </summary>
[OverloadResolutionPriority(3)]
[OverloadResolutionPriority(2)]
public static DictionaryAssertion<TKey, TValue> That<TKey, TValue>(
IReadOnlyDictionary<TKey, TValue>? value,
[CallerArgumentExpression(nameof(value))] string? expression = null)
Expand All @@ -33,7 +33,7 @@ public static DictionaryAssertion<TKey, TValue> That<TKey, TValue>(
/// This overload enables better type inference for dictionary operations like ContainsKey.
/// Example: await Assert.That(dict).ContainsKey("key");
/// </summary>
[OverloadResolutionPriority(2)]
[OverloadResolutionPriority(3)]
public static MutableDictionaryAssertion<TKey, TValue> That<TKey, TValue>(
IDictionary<TKey, TValue>? value,
[CallerArgumentExpression(nameof(value))] string? expression = null)
Expand Down Expand Up @@ -136,7 +136,7 @@ public static AsyncEnumerableAssertion<TItem> That<TItem>(
/// Example: await Assert.That(set).IsSubsetOf(otherSet);
/// Example: await Assert.That(set).Overlaps(otherSet);
/// </summary>
[OverloadResolutionPriority(2)]
[OverloadResolutionPriority(3)]
public static SetAssertion<TItem> That<TItem>(
ISet<TItem>? value,
[CallerArgumentExpression(nameof(value))] string? expression = null)
Expand Down
6 changes: 3 additions & 3 deletions TUnit.PublicAPI/Tests.Assertions_Library_Has_No_API_Changes.DotNet10_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ namespace
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
[.(2)]
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
[.(2)]
[.(3)]
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
[.(1)]
public static .<TItem> That<TItem>(<.<TItem>?> func, [.("func")] string? expression = null) { }
Expand All @@ -208,10 +208,10 @@ namespace
[.(5)]
public static .<TItem> That<TItem>(TItem[]? value, [.("value")] string? expression = null) { }
public static .<TValue> That<TValue>(TValue? value, [.("value")] string? expression = null) { }
[.(2)]
[.(3)]
public static .<TKey, TValue> That<TKey, TValue>(.<TKey, TValue>? value, [.("value")] string? expression = null)
where TKey : notnull { }
[.(3)]
[.(2)]
public static .<TKey, TValue> That<TKey, TValue>(.<TKey, TValue>? value, [.("value")] string? expression = null)
where TKey : notnull { }
public static Throws( exceptionType, action) { }
Expand Down
6 changes: 3 additions & 3 deletions TUnit.PublicAPI/Tests.Assertions_Library_Has_No_API_Changes.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ namespace
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
[.(2)]
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
[.(2)]
[.(3)]
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
[.(1)]
public static .<TItem> That<TItem>(<.<TItem>?> func, [.("func")] string? expression = null) { }
Expand All @@ -208,10 +208,10 @@ namespace
[.(5)]
public static .<TItem> That<TItem>(TItem[]? value, [.("value")] string? expression = null) { }
public static .<TValue> That<TValue>(TValue? value, [.("value")] string? expression = null) { }
[.(2)]
[.(3)]
public static .<TKey, TValue> That<TKey, TValue>(.<TKey, TValue>? value, [.("value")] string? expression = null)
where TKey : notnull { }
[.(3)]
[.(2)]
public static .<TKey, TValue> That<TKey, TValue>(.<TKey, TValue>? value, [.("value")] string? expression = null)
where TKey : notnull { }
public static Throws( exceptionType, action) { }
Expand Down
Loading