fix(api): localize calendar-sync notifications

[thomasluizon]

Pairs with thomasluizon/orbit-ui-mobile#381 (no contract coupling; merge order free). User report: notification bell showed "2 new calendar events / Tap to review and import" in a pt-BR app.

Both hardcoded-English sites in RunCalendarAutoSyncCommand fixed via the house LocaleHelper.IsPortuguese(user.Language) pattern: the suggestions notification (proper pt pluralization) and the Google-disconnected reconnect notification (copy matches the clients' existing calendarSync.reconnect strings). Exhaustive 17-site audit of every notification/push creation site: all others already localized. Already-persisted rows keep their frozen text.

Tests: 32 passed on the handler suite (5 new: en/pt plural + singular suggestion, en/pt reconnect). Build clean, no bare comments.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[claude]

Code Review: PR #279

Scope: PR #279 in thomasluizon/orbit-api — "fix(api): localize calendar-sync notifications (pt-BR/en)"
Recommendation: APPROVE

Summary

The diff replaces two hardcoded-English notification strings in RunCalendarAutoSyncCommandHandler (src/Orbit.Application/Calendar/Commands/RunCalendarAutoSyncCommand.cs) — the new-suggestions notification and the Google-disconnected/reconnect notification — with pt-BR/English variants gated on LocaleHelper.IsPortuguese(user.Language). This is the same helper already used at 15+ other call sites across the codebase (Referrals, Accountability, Social, Gamification, Reminder/StreakFreeze/GoalDeadline/ResendEmail services), so the fix is a drop-in application of an existing house pattern, not a new mechanism. 5 new unit tests cover en/pt × singular/plural for the suggestions notification and en/pt for the reconnect notification, and the fixed TimeProvider in the test fixture (2026-04-09 14:00 UTC, UTC timezone) correctly lands inside the existing quiet-hours window so the notification-creation path is actually exercised.

Findings

Critical: None.
High: None.
Medium: None.

Low / Info:

• Grepped every Notification.Create(...) call site under src/ — all others already route title/body through locale-aware helpers or pre-localized variables. The PR body's claim of an "exhaustive 17-site audit" with no remaining hardcoded-English site in this file checks out.
• The CreateSuggestionNotification signature change (Guid userId → User user) is the minimal change needed to reach user.Language; its single call site in FetchAndProcessLocked was updated in the same diff, no orphaned overload left behind.
• Portuguese pluralization is handled correctly (novo/novos agreement), not a naive string concat.

Subagents

Agent	Verdict
security-reviewer	PASS — diff only swaps fixed string literals behind a boolean locale branch; count is an int, no user-controlled string is interpolated into notification title/body, no new endpoint/auth/DTO surface
contract-aligner	N/A — no DTO, Controller route, or packages/shared type touched

Validation

Check	Result
Build (dotnet)	N/A — covered by the separate required CI Build check
Tests (dotnet)	N/A — covered by the separate required CI Unit Tests check

What's good

• Reuses LocaleHelper.IsPortuguese(user.Language) exactly as used elsewhere rather than inventing new localization plumbing.
• Test coverage added for every new branch in the same PR, per tests/CLAUDE.md.
• Already-persisted notification rows are explicitly left frozen — correct call, avoids an out-of-scope backfill/migration.

Recommendation

No changes requested. Safe to merge.