Fixed some problems, like methods not found and variables. Made it wo…#14
Closed
schirrel wants to merge 7 commits intothinkyhead:rc_filament_change_toofrom
Closed
Fixed some problems, like methods not found and variables. Made it wo…#14schirrel wants to merge 7 commits intothinkyhead:rc_filament_change_toofrom
schirrel wants to merge 7 commits intothinkyhead:rc_filament_change_toofrom
Conversation
…rk at the first behaviors: 1 slow insert till the filament gets catch; 2 insert total filament tru bowden tub; 3 eject all the filament tru the tube; Missing the part where while the 2 and 3 it be possible to stop
Marlin/ultralcd.cpp
Outdated
| static void lcd_eject_filament() { lcd_mfc_move(MFC_EJECTING, -1.0); } | ||
| static void lcd_insert_filament() { lcd_mfc_move(MFC_INSERTING, 1.0); } | ||
| static void lcd_insert_filament_slow_callback() { lcd_mfc_move(MFC_INSERTING_SLOW, 1.0, 1.5); } | ||
| static void lcd_eject_filament() { lcd_mfc_move(MFC_EJECTING BOWDEN_LENGTH, FILAMENT_CHANGE_NORMAL_SPEED); } |
Marlin/Configuration_adv.h
Outdated
| #define AUTO_FILAMENT_CHANGE_FEEDRATE 300 //Extrusion feedrate (mm/min) on automatic extrusion loop | ||
|
|
||
| #if ENABLED(MANUAL_FILAMENT_CHANGE) | ||
| #define FILAMENT_LOAD_LENGTH 55 //i guess it's in cm |
Owner
There was a problem hiding this comment.
// I'm really positive that it's centimeters…or just…
// cm…is fine…
Author
There was a problem hiding this comment.
Yes i know i've put this way to remenber to discuss with u.
Because in my last code i used mm, so my bowden is 55cm distante, i was using 550, but when i was using this, i wasnt with filament around, and with 550 it seems to be much more then 550mm, so i was to ask you, what is the default measure for this
Owner
There was a problem hiding this comment.
mm would be best, in my opinion. I think of almost everything on my printer in mm, especially extrusion-related things. But there is at least one setting specified in cm:
#define MEASUREMENT_DELAY_CM 14cff6c21 to
a589328
Compare
5c0577c to
df7d174
Compare
02f59b1 to
64ebbe5
Compare
dbc89f2 to
76ec16a
Compare
7817e51 to
060a6b4
Compare
060a6b4 to
dd690ac
Compare
b4d1ed4 to
5fc24f5
Compare
thinkyhead
pushed a commit
that referenced
this pull request
Aug 24, 2019
# This is the 1st commit message: Add Support for ADIMLab Granty # The commit message #2 will be skipped: # Update Configuration.h # The commit message #3 will be skipped: # Add files via upload # # Add Support for ADIMLab Granty # The commit message #4 will be skipped: # Create Configuration.h # The commit message #5 will be skipped: # Delete Configuration.h # The commit message #6 will be skipped: # Create Test.h # The commit message #7 will be skipped: # Add files via upload # The commit message #8 will be skipped: # Delete Test.h # The commit message #9 will be skipped: # Delete Configuration.h # The commit message #10 will be skipped: # Delete Configuration_adv.h # The commit message #11 will be skipped: # Add files via upload # # Add ADIMLab Pins # The commit message #12 will be skipped: # Add files via upload # # Add Bootscreen # The commit message #13 will be skipped: # Update Configuration.h # # Add Bootscreen # The commit message #14 will be skipped: # Update pins.h # # Add ADIMLab Board # The commit message #15 will be skipped: # Update boards.h # # Add ADIMLab Granty # The commit message #16 will be skipped: # Update Makefile # # Add ADIMLab Granty # The commit message #17 will be skipped: # Update boards.h # The commit message #18 will be skipped: # Update Makefile
thinkyhead
added a commit
that referenced
this pull request
Aug 24, 2019
* # This is a combination of 18 commits. # This is the 1st commit message: Add Support for ADIMLab Granty # The commit message #2 will be skipped: # Update Configuration.h # The commit message #3 will be skipped: # Add files via upload # # Add Support for ADIMLab Granty # The commit message #4 will be skipped: # Create Configuration.h # The commit message #5 will be skipped: # Delete Configuration.h # The commit message #6 will be skipped: # Create Test.h # The commit message #7 will be skipped: # Add files via upload # The commit message #8 will be skipped: # Delete Test.h # The commit message #9 will be skipped: # Delete Configuration.h # The commit message #10 will be skipped: # Delete Configuration_adv.h # The commit message #11 will be skipped: # Add files via upload # # Add ADIMLab Pins # The commit message #12 will be skipped: # Add files via upload # # Add Bootscreen # The commit message #13 will be skipped: # Update Configuration.h # # Add Bootscreen # The commit message #14 will be skipped: # Update pins.h # # Add ADIMLab Board # The commit message #15 will be skipped: # Update boards.h # # Add ADIMLab Granty # The commit message #16 will be skipped: # Update Makefile # # Add ADIMLab Granty # The commit message #17 will be skipped: # Update boards.h # The commit message #18 will be skipped: # Update Makefile * Add Support for ADIMLab Granty * Optimize bootscreen * Update Makefile Updated Description * Update boards.h Updated Description * Update pins_HJC2560C_REV2.h Updated Description * Update Configuration.h Added Author + Custom_Machine_Name * Create _Bootscreen.h Add Bootscreen * Add files via upload Add ADIMLab Granty v1 * Update boards.h Add ADIMLab Granty v1 * Update Makefile Add ADIMLab Granty v1 * Update pins_HJC2560C_REV2.h * Consolidate Granty configs * config updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rk at the first behaviors: 1 slow insert till the filament gets catch; 2 insert total filament tru bowden tub; 3 eject all the filament tru the tube; Missing the part where while the 2 and 3 it be possible to stop