xtensa-build-zephyr: guess CMake successes and failures better #5016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent commit b9fcc41 ("xtensa-build-zephyr: fix incremental build, pass CMAKE_ARGS only once") fixed incremental builds. For this it first needs to guess whether the most recent CMake configuration step failed or succeeded so it knows what is the current "checkpoint" and what is the next west command to run. Merely testing whether the build directory already exists is a very bad guess because that directory could have been created by some other person or script, or - much worse - it could have been created by a failed CMake configuration step! The latter situation makes debugging CMake failures very tedious because it requires manually deleting the build directory after each CMake configuration failure. Fix this by not merely looking for a build directory but by looking whether there is either a build.ninja or a Makefile is found in that directory. This is a much better indication that the CMake configuration succeeded. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
requested review from
aiChaoSONG,
fredoh9,
greg-intel,
keqiaozhang,
kv2019i,
lgirdwood and
lyakh
lgirdwood
approved these changes
Nov 21, 2021
Member
|
Thanks @marc-hb useful for rc1. Failures unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent commit b9fcc41 ("xtensa-build-zephyr: fix incremental build,
pass CMAKE_ARGS only once") fixed incremental builds. For this it first
needs to guess whether the most recent CMake configuration step failed
or succeeded so it knows what is the current "checkpoint" and what is
the next west command to run. Merely testing whether the build directory
already exists is a very bad guess because that directory could have
been created by some other person or script, or - much worse - it could
have been created by a failed CMake configuration step!
The latter situation makes debugging CMake failures very tedious because
it requires manually deleting the build directory after each CMake
configuration failure.
Fix this by not merely looking for a build directory but by looking
whether there is either a build.ninja or a Makefile is found in that
directory. This is a much better indication that the CMake configuration
succeeded.
Signed-off-by: Marc Herbert [email protected]