xtensa-build-zephyr: fix incremental build, pass CMAKE_ARGS only once #5003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented in https://docs.zephyrproject.org/latest/guides/west/build-flash-debug.html#one-time-cmake-arguments and accidentally found when testing rimage cleanup zephyrproject-rtos/zephyr#40431 Fixes commit 88327f6 ("xtensa-build-zephyr: support passing through CMake arguments"); ccache is too good and hid this regression from me. Signed-off-by: Marc Herbert <[email protected]>
Collaborator
Author
|
Unrelated, ICL-specific failure in https://github.com/thesofproject/sof/runs/4246023113?check_suite_focus=true EDIT: bisected to revert zephyrproject-rtos/zephyr#40319 |
Collaborator
Author
|
Funny coincidence, XTOS ICL was successfully buildt but did not run any smoke tests in https://sof-ci.01.org/sof-pr-viewer/#/build/PR5003/build7916363 |
kv2019i
approved these changes
Nov 18, 2021
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Seems to work great, thanks!
Collaborator
|
@marc-hb For the ICL build fail, Andy's cleanup patch might actually help as it unifies the linker scripts (just guessing though). If not, I'd say let's drop icl for now as we cannot regularly test it. |
Collaborator
Author
|
Temporarily excluding ICL in #5005 |
lgirdwood
approved these changes
Nov 18, 2021
Collaborator
Author
|
Fixup in #5016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in
https://docs.zephyrproject.org/latest/guides/west/build-flash-debug.html#one-time-cmake-arguments
and accidentally found when testing rimage cleanup
zephyrproject-rtos/zephyr#40431
Fixes commit 88327f6 ("xtensa-build-zephyr: support passing through
CMake arguments"); ccache is too good and hid this regression from me.
Signed-off-by: Marc Herbert [email protected]