Repository navigation
feat(models): add fireworks + together deepseek v4 - #3484
Conversation
Adds Fireworks as a provider for DeepSeek V4 Pro (accounts/fireworks/models/deepseek-v4-pro), 1.74 / 3.48 per 1M tokens with 0.145 cached input, up to 1M context. Co-Authored-By: Claude <noreply@anthropic.com>
Adds Together AI as a provider for DeepSeek V4 Flash (deepseek-ai/DeepSeek-V4-Flash-0731), 0.14 / 0.28 per 1M tokens with 0.03 cached input. Co-Authored-By: Claude <noreply@anthropic.com>
…missing-providers
Together's DeepSeek V4 Flash deployment was declared tools: false and jsonOutput: false based on the model card listing Chat + Reasoning only. The live deployment returns well-formed tool_calls with finish_reason "tool_calls", and honours both response_format json_object and json_schema — matching its together-ai V4 Pro sibling, which already declares all three. Under-declaring routed tool and JSON traffic away from the provider and hid those paths from e2e entirely. Also restore the WHY comments on both trimmed reasoningEfforts lists, which were copied from their siblings without the explanations. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GNFpeYxUh39cCdbp7Ttjud
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe model definitions add Fireworks support for DeepSeek V4 Pro and Together AI support for DeepSeek V4 Flash, including provider-specific pricing, context limits, reasoning controls, and structured output capabilities. ChangesDeepSeek V4 provider integrations
Estimated code review effort: 3 (Moderate) | ~15 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Supersedes #3431. Carries @vicovaro's two DeepSeek V4 provider mappings unchanged (their commits are preserved with authorship intact), rebuilt on current
main, plus one capability correction found while verifying the mappings against the live providers.What & why
Adds the two missing DeepSeek V4 provider mappings — Fireworks for V4 Pro and Together AI for V4 Flash. Both providers already serve the sibling V4 model in the catalogue, so this closes the gaps. Only
packages/models/src/models/deepseek.tschanges; no gateway logic.externalIdaccounts/fireworks/models/deepseek-v4-prodeepseek-ai/DeepSeek-V4-Flash-0731Capability correction on top of #3431
#3431 declared the Together V4 Flash mapping
tools: false, jsonOutput: false, on the basis that Together's model card lists Chat + Reasoning only. Probing the live deployment shows the card understates it:tool_callswithfinish_reason: "tool_calls"response_format: json_object) — honouredresponse_format: json_schema) — honoured, schema respectedThis matches the
together-aiV4 Pro mapping, which already declares all three. The mapping now setstools: true,jsonOutput: true,jsonOutputSchema: true.The practical effect of the original values was not mis-billing but silent under-routing: the gateway would have steered tool-calling and JSON traffic away from Together for this model, users pinning
together-ai/deepseek-v4-flashwould lose those features, and — because afalseflag generates no test case — e2e would never have covered those paths.Both mappings also had trimmed
reasoningEffortslists copied from their siblings without the siblings' explanatory comments; those are restored, per the repo convention that a non-obvious restricted list keeps its rationale.Not changed: the Fireworks Pro mapping carries no
quantizationfield. #3431's description called it FP8, but Fireworks'/v1/modelsreports no quantization and the Fireworks V4 Flash sibling doesn't declare one either, so it seemed wrong to assert it in the catalogue. Worth a follow-up if someone can confirm from the deployment.Verification
TEST_MODELS="fireworks/deepseek-v4-pro,together-ai/deepseek-v4-flash" pnpm test:e2eZero failures. The correction raises the count from 110 to 119 — the 9 additional tests are exactly the Together paths the
falseflags had suppressed:chat-json6→10,chat-toolcalls4→6,chat-toolcalls-result3→4,responses8→10.Also verified: both
externalIds resolve upstream; per-token cost math matches the declared rates exactly (106 prompt tokens → $0.00001484 at $0.14/M, 82 completion → $0.00002296 at $0.28/M); the Fireworksprioritytier resolves and applies its 1.5× multiplier in both sync and streaming;requiresDisableThinkingParamandreasoningOutput: "omit"behave correctly on Together (reasoning tokens counted, no reasoning text emitted); Fireworks streamsreasoning_contentas expected.packages/modelscatalogue specs pass (131 tests).Generated by Claude Code
Summary by CodeRabbit