Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdded Fireworks support for DeepSeek V4 Pro and Together AI support for DeepSeek V4 Flash. Each provider includes model-specific pricing, context, reasoning, and output capability settings. ChangesDeepSeek V4 provider configurations
Estimated code review effort: 3 (Moderate) | ~15–30 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds Fireworks as a provider for DeepSeek V4 Pro (accounts/fireworks/models/deepseek-v4-pro), 1.74 / 3.48 per 1M tokens with 0.145 cached input, up to 1M context. Co-Authored-By: Claude <noreply@anthropic.com>
Adds Together AI as a provider for DeepSeek V4 Flash (deepseek-ai/DeepSeek-V4-Flash-0731), 0.14 / 0.28 per 1M tokens with 0.03 cached input. Co-Authored-By: Claude <noreply@anthropic.com>
abf4f05 to
adb923c
Compare
|
Synced this with I also pushed one commit adding the why-comment for the Three things I couldn't verify without provider keys — could you confirm before this merges? 1. Together This is the only dated Together id in the entire catalogue, and it's byte-identical to the 2. Your V4 Pro mapping on the same provider declares 3. The list omits Also worth double-checking |
|
Superseded by #3484 — closing this one in favour of it. Thanks @vicovaro; your two commits are carried over there unchanged, with authorship preserved. I ran the e2e suite you suggested against both mappings. Everything passed, but the run also surfaced one thing e2e structurally cannot catch, so I folded a fix into the successor PR rather than merging as-is.
That also matches the The other small thing: both new mappings copied trimmed One open question I left alone: the description here calls the Fireworks Pro deployment FP8, but no Generated by Claude Code |
Supersedes #3431. Carries @vicovaro's two DeepSeek V4 provider mappings unchanged (their commits are preserved with authorship intact), rebuilt on current `main`, plus one capability correction found while verifying the mappings against the live providers. ## What & why Adds the two missing DeepSeek V4 provider mappings — **Fireworks** for V4 Pro and **Together AI** for V4 Flash. Both providers already serve the sibling V4 model in the catalogue, so this closes the gaps. Only `packages/models/src/models/deepseek.ts` changes; no gateway logic. | Model | Provider | `externalId` | Input / Cached / Output per 1M | Context | |---|---|---|---|---| | deepseek-v4-pro | fireworks | `accounts/fireworks/models/deepseek-v4-pro` | $1.74 / $0.145 / $3.48 | 1M | | deepseek-v4-flash | together-ai | `deepseek-ai/DeepSeek-V4-Flash-0731` | $0.14 / $0.03 / $0.28 | 163K | ## Capability correction on top of #3431 #3431 declared the Together V4 Flash mapping `tools: false, jsonOutput: false`, on the basis that Together's model card lists Chat + Reasoning only. Probing the live deployment shows the card understates it: - **Tools** — returns a well-formed `tool_calls` with `finish_reason: "tool_calls"` - **JSON mode** (`response_format: json_object`) — honoured - **JSON schema** (`response_format: json_schema`) — honoured, schema respected This matches the `together-ai` V4 Pro mapping, which already declares all three. The mapping now sets `tools: true`, `jsonOutput: true`, `jsonOutputSchema: true`. The practical effect of the original values was not mis-billing but silent under-routing: the gateway would have steered tool-calling and JSON traffic away from Together for this model, users pinning `together-ai/deepseek-v4-flash` would lose those features, and — because a `false` flag generates no test case — e2e would never have covered those paths. Both mappings also had trimmed `reasoningEfforts` lists copied from their siblings without the siblings' explanatory comments; those are restored, per the repo convention that a non-obvious restricted list keeps its rationale. Not changed: the Fireworks Pro mapping carries no `quantization` field. #3431's description called it FP8, but Fireworks' `/v1/models` reports no quantization and the Fireworks V4 Flash sibling doesn't declare one either, so it seemed wrong to assert it in the catalogue. Worth a follow-up if someone can confirm from the deployment. ## Verification `TEST_MODELS="fireworks/deepseek-v4-pro,together-ai/deepseek-v4-flash" pnpm test:e2e` ``` Test Files 29 passed | 2 skipped (31) Tests 119 passed | 91 skipped (210) ``` Zero failures. The correction raises the count from 110 to 119 — the 9 additional tests are exactly the Together paths the `false` flags had suppressed: `chat-json` 6→10, `chat-toolcalls` 4→6, `chat-toolcalls-result` 3→4, `responses` 8→10. Also verified: both `externalId`s resolve upstream; per-token cost math matches the declared rates exactly (106 prompt tokens → $0.00001484 at $0.14/M, 82 completion → $0.00002296 at $0.28/M); the Fireworks `priority` tier resolves and applies its 1.5× multiplier in both sync and streaming; `requiresDisableThinkingParam` and `reasoningOutput: "omit"` behave correctly on Together (reasoning tokens counted, no reasoning text emitted); Fireworks streams `reasoning_content` as expected. `packages/models` catalogue specs pass (131 tests). --- _Generated by [Claude Code](https://claude.ai/code/session_01GNFpeYxUh39cCdbp7Ttjud)_ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added Fireworks as a provider for DeepSeek V4 Pro. * Added Together AI as a provider for DeepSeek V4 Flash. * Added support for provider-specific pricing, capacity, reasoning, tool use, and JSON output capabilities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Li Tai Chen <dev@taichen.li> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: smakosh <ismai23l@hotmail.com>
Note: any
deepseek-v4-flashusage implicitly resolves to the-0731deployment — see #3341 (closed).What & why
Adds the two missing DeepSeek V4 provider mappings: Fireworks for V4 Pro and Together AI for V4 Flash. Both providers already serve the sibling DeepSeek V4 model in the catalog (Fireworks hosts V4 Flash, Together hosts V4 Pro); this PR closes the gaps.
Only
packages/models/src/models/deepseek.tschanges — catalog metadata, no gateway logic.Changes (two commits)
externalIdfeat(models): add fireworks deepseek-v4-pro mappingaccounts/fireworks/models/deepseek-v4-profeat(models): add together-ai deepseek-v4-flash mappingdeepseek-ai/DeepSeek-V4-Flash-0731reasoningOutput: "omit"); Together's card lists Chat + Reasoning only — no function calling / JSON modeReferences
accounts/fireworks/models/deepseek-v4-pro, $1.74/$3.48, up to 1M context, function callingreasoning_effortacceptsnone/low/medium/high/xhigh/maxdeepseek-ai/DeepSeek-V4-Flash-0731, $0.14/$0.28, cached $0.03, Chat + Reasoning tagsTests to run as reviewers
TEST_MODELS="fireworks/deepseek-v4-pro,together-ai/deepseek-v4-flash" pnpm test:e2e🤖 Generated with Claude Code
Summary by CodeRabbit