-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PHP 8.0 #8
Conversation
@theofidry maybe move Travis to Git Hub Actions? Now Travis build did not work. |
I'll welcome a switch but I can't work on it myself at the moment; that said a PHP8 build is likely to not be working due to requiring Composer 2 which is blocked by wikimedia/composer-merge-plugin#189 |
Why composer 2 is required ? Can't the tests run with composer 1 ? |
You can use |
Right actually if Composer 1 works with PHP8 there is no issue |
https://github.com/composer/composer/blob/1.10/composer.json#L25 |
@Yozhef we'll have to use Composer 1 for now, please try to add Adding
before |
@alexislefebvre Today I want to implement GitHub Actions here too - and will I change it well there? |
I suggest you to try to use Travis CI with this change, and switch to GitHub Actions if it doesn't work. If it works, we could switch to GA later in another PR. |
@alexislefebvre Okey. |
0da1e24
to
0728e95
Compare
It looks like Travis CI didn't run the tests. |
#9 merged; if it's of any help I'm fine with dropping support for anything bellow 7.3 |
@theofidry Faile - 7.1 and 7.2 - Maybe you'll tell me - I can downgrade the PHP version locally for debugging but a little later |
1b69ed0
to
1a5ebaf
Compare
Alright let's see if it works! Thanks @Yozhef |
Could you please publish a new release? |
No description provided.