Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.0 #8

Merged
merged 8 commits into from
Jan 18, 2021
Merged

Support PHP 8.0 #8

merged 8 commits into from
Jan 18, 2021

Conversation

Yozhef
Copy link
Contributor

@Yozhef Yozhef commented Dec 9, 2020

No description provided.

@Yozhef
Copy link
Contributor Author

Yozhef commented Dec 9, 2020

@theofidry maybe move Travis to Git Hub Actions? Now Travis build did not work.

@theofidry
Copy link
Owner

I'll welcome a switch but I can't work on it myself at the moment; that said a PHP8 build is likely to not be working due to requiring Composer 2 which is blocked by wikimedia/composer-merge-plugin#189

@VincentLanglet
Copy link

I'll welcome a switch but I can't work on it myself at the moment; that said a PHP8 build is likely to not be working due to requiring Composer 2 which is blocked by wikimedia/composer-merge-plugin#189

Why composer 2 is required ? Can't the tests run with composer 1 ?

@alexislefebvre
Copy link

You can use composer self-update --1 to keep using Composer 1 until issues are solved.

@theofidry
Copy link
Owner

Why composer 2 is required ? Can't the tests run with composer 1 ?

Right actually if Composer 1 works with PHP8 there is no issue

@VincentLanglet
Copy link

Why composer 2 is required ? Can't the tests run with composer 1 ?

Right actually if Composer 1 works with PHP8 there is no issue

https://github.com/composer/composer/blob/1.10/composer.json#L25

@alexislefebvre
Copy link

@Yozhef we'll have to use Composer 1 for now, please try to add composer self-update --1 before running the tests.

Adding

before_script:
  - composer self-update --1

before script: make in .travis.yml should fix the issue hopefully.

@Yozhef
Copy link
Contributor Author

Yozhef commented Jan 13, 2021

@alexislefebvre Today I want to implement GitHub Actions here too - and will I change it well there?

@alexislefebvre
Copy link

I suggest you to try to use Travis CI with this change, and switch to GitHub Actions if it doesn't work. If it works, we could switch to GA later in another PR.

@Yozhef
Copy link
Contributor Author

Yozhef commented Jan 13, 2021

@alexislefebvre Okey.
In This PR ready move to GitHub Actions:
#9
But have 1 point in php version 7.1 7.2 - it is not clear what the problem is but I watched the don already live quite a long time

@Yozhef Yozhef force-pushed the php8 branch 2 times, most recently from 0da1e24 to 0728e95 Compare January 13, 2021 15:06
@alexislefebvre
Copy link

It looks like Travis CI didn't run the tests.

@theofidry
Copy link
Owner

#9 merged; if it's of any help I'm fine with dropping support for anything bellow 7.3

@Yozhef
Copy link
Contributor Author

Yozhef commented Jan 13, 2021

@theofidry
Failed 8.0 theofidry/composer-inheritance-plugin this is normal because the tests pull this package master version in which there is no support for PHP 8.0.

Faile - 7.1 and 7.2 - Maybe you'll tell me - I can downgrade the PHP version locally for debugging but a little later

@Yozhef Yozhef force-pushed the php8 branch 4 times, most recently from 1b69ed0 to 1a5ebaf Compare January 13, 2021 19:31
@theofidry theofidry merged commit b18cb03 into theofidry:master Jan 18, 2021
@theofidry
Copy link
Owner

Alright let's see if it works! Thanks @Yozhef

@alexislefebvre
Copy link

Could you please publish a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants