-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PHP 8.0 #158
Support PHP 8.0 #158
Conversation
f0ed1e1
to
c1dc3fb
Compare
It will require an update from https://github.com/nelmio/alice |
@theofidry any news on this ? |
This PR is blocked by a PR that is blocked by another PR. 😅 |
@alexislefebvre nelmio/alice#1064 is done =) |
2e5caee
to
b399fe0
Compare
It is blocked by theofidry/composer-inheritance-plugin#8 now. |
cead4ab
to
060f4a6
Compare
060f4a6
to
a750a11
Compare
https://github.com/doctrine/mongodb-odm doesn't support PHP 8 yet (PHP 8 is allowed on |
b7038ec
to
9d9e14e
Compare
Can't we skip temporary the mongo-related test on php8 ? |
I thought about that, and I think it would be confusing to publish a new release that may break users' tests (if they didn't locked their dependencies, that's a good practice but some users don't do that). To avoid this, a new release which declare conflicts with the Mongo packages could be published. |
Why will it break the users tests ? User without mongo, will be able to upgrade to PHP8, user with mongo won't be able to upgrade to PHP8 ; not because of us, but because of mongo which doesn't currently support PHP8. There is no change in the code. |
@VincentLanglet you're totally right, I overthought that. 🙂 |
The composer-inheritance-plugin is now solved, so this work should be resumed |
6c81ea5
to
112e8fc
Compare
112e8fc
to
f7be2d2
Compare
|
Thank you! |
Allow PHP8