Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.0 #158

Merged
merged 6 commits into from
Jan 25, 2021
Merged

Support PHP 8.0 #158

merged 6 commits into from
Jan 25, 2021

Conversation

alexislefebvre
Copy link
Contributor

@alexislefebvre alexislefebvre commented Dec 9, 2020

Allow PHP8

@alexislefebvre
Copy link
Contributor Author

It will require an update from https://github.com/nelmio/alice

See nelmio/alice#1064

@nicodmf
Copy link

nicodmf commented Dec 21, 2020

@theofidry any news on this ?

@alexislefebvre
Copy link
Contributor Author

This PR is blocked by a PR that is blocked by another PR. 😅

@Yozhef
Copy link

Yozhef commented Jan 13, 2021

@alexislefebvre nelmio/alice#1064 is done =)

@alexislefebvre
Copy link
Contributor Author

It is blocked by theofidry/composer-inheritance-plugin#8 now.

@alexislefebvre
Copy link
Contributor Author

alexislefebvre commented Jan 18, 2021

https://github.com/doctrine/mongodb-odm doesn't support PHP 8 yet (PHP 8 is allowed on master branch but it hasn't been released yet).

@alexislefebvre alexislefebvre force-pushed the support-php-8.0 branch 2 times, most recently from b7038ec to 9d9e14e Compare January 19, 2021 13:23
@VincentLanglet
Copy link
Contributor

Can't we skip temporary the mongo-related test on php8 ?
Doctrine/orm supports php8, it should be allowed to use this package on php8 if we don't use mongo.

@alexislefebvre
Copy link
Contributor Author

alexislefebvre commented Jan 20, 2021

I thought about that, and I think it would be confusing to publish a new release that may break users' tests (if they didn't locked their dependencies, that's a good practice but some users don't do that).

To avoid this, a new release which declare conflicts with the Mongo packages could be published.

@VincentLanglet
Copy link
Contributor

I thought about that, and I think it would be confusing to publish a new release that may break users' tests (if they didn't locked their dependencies, that's a good practice but some users don't do that).

Why will it break the users tests ?
You're just allowing php8 in this PR.

User without mongo, will be able to upgrade to PHP8, user with mongo won't be able to upgrade to PHP8 ; not because of us, but because of mongo which doesn't currently support PHP8.

There is no change in the code.
If someone use this library on PHP7.4 with mongo, it will still work the same ; proof => test are green on 7.4 with mongo.

@alexislefebvre
Copy link
Contributor Author

@VincentLanglet you're totally right, I overthought that. 🙂

@stof
Copy link
Contributor

stof commented Jan 21, 2021

The composer-inheritance-plugin is now solved, so this work should be resumed

@alexislefebvre alexislefebvre force-pushed the support-php-8.0 branch 2 times, most recently from 6c81ea5 to 112e8fc Compare January 22, 2021 21:33
@alexislefebvre
Copy link
Contributor Author

alexislefebvre commented Jan 22, 2021

One job looks dead but the PHP8 job is green. Feel free to review the changes.

@theofidry theofidry merged commit bcfdf64 into theofidry:master Jan 25, 2021
@theofidry
Copy link
Owner

Thank you!

@alexislefebvre alexislefebvre deleted the support-php-8.0 branch January 25, 2021 10:32
@alexislefebvre alexislefebvre restored the support-php-8.0 branch February 1, 2021 19:57
@alexislefebvre alexislefebvre deleted the support-php-8.0 branch February 1, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants