Get vex-hugo ready for submission to themes.gohugo.io #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hugo 0.16 is the first version that supports {{- -}} space trimming
in templates.
- Change non-existent languageCode "en-en" to "en" - Fix params order for custom_stylesheets and custom_scripts to work - Fix typo in header: "Belive" → "Believe" - Remove reference about Themefisher license because Vex for Hugo has been relicensed under the MIT License
And make indentation in the source HTML file consistent.
|
Hi @mehedi-sharif, If you intend to use CC-BY-3.0 rather than MIT as the license for the Vex (for Hugo) theme, please let me know, and I'll adjust this pull request accordingly. |
|
I think CC-BY-3.0 if fine for me rather than MIT. When I first submit my theme to hugo I saw that require to MIT but after visiting few themes I saw that is some themes under CC-BY-3.0. So I think it will be great for me CC-BY-3.0. |
Done! Please see Pull Request #2 to change the license to CC-BY-3.0. |
nhpp-digitizeafrika
pushed a commit
to nhpp-digitizeafrika/vex-hugo
that referenced
this pull request
Dec 30, 2020
allow links in social of footer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should get the Hugo port of Vex in shape for inclusion on https://themes.gohugo.io/ as requested in gohugoio/hugoThemes#330.
Thanks!