Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Submit Themefisher free themes to hugo theme collection #330

Closed
mehedi-sharif opened this issue Feb 5, 2018 · 24 comments
Closed

Submit Themefisher free themes to hugo theme collection #330

mehedi-sharif opened this issue Feb 5, 2018 · 24 comments

Comments

@mehedi-sharif
Copy link

Hey team,
I have changed the license and make my themes under mit license .
Here is the links
1- https://github.com/themefisher/vex-hugo
2- https://github.com/themefisher/airspace-hugo
I will be glad if you guys add my template in hugo theme directory
Thanks

@bep
Copy link
Member

bep commented Feb 5, 2018

Please add a standard license text so we know what MIT license you're talking about, e.g.

https://github.com/spf13/cast/blob/master/LICENSE

@mehedi-sharif
Copy link
Author

Yes I have updated the license. Thanks for your feedback.

@mehedi-sharif
Copy link
Author

I am seeing a template added their license as Creative Commons Attribution 3.0 . Can I also switch my license MIT to Creative Commons Attribution 3.0 ?
Thanks

@bep
Copy link
Member

bep commented Feb 25, 2018

@mehedi-sharif sorry for the delay. Yes, CCA is fine, but please add a proper license file (see below) + the relevant license name in theme.toml.

See

https://creativecommons.org/2014/01/07/plaintext-versions-of-creative-commons-4-0-licenses/

For text files.

@digitalcraftsman
Copy link
Member

Hi @mehedi-sharif,

while checking the Vex theme repository I noticed a few issues:

The points on this list also apply to the Airspace theme.

@bep the currently used license (MIT) is mentioned in both theme.toml files. @mehedi-sharif are you planing to switch to the CCA license or do you stick with MIT?

@digitalcraftsman
Copy link
Member

Any updates here?

@mehedi-sharif
Copy link
Author

@karjudev Could you please fix this issues . @digitalcraftsman yeah we are going to fix this issues soon.

@karjudev
Copy link

karjudev commented Apr 7, 2018

@mehedi-sharif @digitalcraftsman apologies for the delay, I fixed theme.toml config.toml. I'll upload a screenshot and a thumbnail soon.

@karjudev
Copy link

karjudev commented Apr 9, 2018

Ok, I uploaded the screenshot and the thumbnail for Vex and I fixed the Airspace's BaseURL.

@digitalcraftsman
Copy link
Member

Ok, I uploaded the screenshot and the thumbnail for Vex

The screenshots are a bit large. The thumbnail should have the dimenions 900px × 600px and the screenshot 1500px × 1000px.

Could you also add an empty data and content folder to the exampleSite directory of the Vex theme?

@mehedi-sharif
Copy link
Author

@karjudev here is another changes :) hope you will fix this issues :)

@bep
Copy link
Member

bep commented Apr 9, 2018

The README(s) should also be updated re. the license. It is MIT?

This Hugo theme is a port of Themefisher’s Vex - Bootstrap 4 Product Landing Page. It is released under Themefisher’s free license, which requires attribution.

@mehedi-sharif
Copy link
Author

Can I use Creative Common Attribution 3.0 License ? @bep .
Thanks

@bep
Copy link
Member

bep commented Apr 9, 2018

Can I use Creative Common Attribution 3.0 License ? @bep .

I have answered this before. Yes, you can.

Note that I'm not a license expert, and that is certainly not the case for the common Hugo theme user. We have a fair amount of HTML5Up themes with that license, and they are easy to understand.

But also note that I don't want any commercial/advertisement lingo in the README if we're going to add it to the theme site.

So no "you can buy a commercial license 50% off at ..." So, feel free to link back to the theme source, but make it neutral.

@mehedi-sharif
Copy link
Author

Changed all issues .. Could you please check now .
Thanks

@digitalcraftsman
Copy link
Member

I've added the airspace theme and I'll announce it on Twitter.

Could you also add an empty data and content folder to the exampleSite directory of the Vex theme? Otherwise the build script for theme site is unable to generate a demo. Adding an empty file, e.g. named .gitkeep, is sufficient.

digitalcraftsman added a commit that referenced this issue Apr 17, 2018
@mehedi-sharif
Copy link
Author

@karjudev could you please add some dummy data ..
Thanks

@mehedi-sharif
Copy link
Author

@digitalcraftsman Could you please check the author name Giacomo Mariani
to themefisher with my website url :)
https://themes.gohugo.io/airspace-hugo/
Thanks

@digitalcraftsman
Copy link
Member

digitalcraftsman commented May 12, 2018

The shown metadata can be updated in the theme.toml. Then I can pull the latest commits from all themes and trigger a rebuild of a the theme site.

@mehedi-sharif
Copy link
Author

I have changed from my repo. Now you can pull .
Thanks

@digitalcraftsman
Copy link
Member

Done

@anthonyfok anthonyfok changed the title Submit our free themes to huge theme collection Submit our free themes to hugo theme collection May 30, 2018
@anthonyfok anthonyfok changed the title Submit our free themes to hugo theme collection Submit Themefisher free themes to hugo theme collection May 30, 2018
@anthonyfok
Copy link
Member

Now that both airspace-hugo and vex-hugo are added to hugoThemes, it is time to close this issue. :-)

@digitalcraftsman
Copy link
Member

Thanks @anthonyfok for stepping in.
@mehedi-sharif I'll promote your Vex theme as well. It's great to see more of your themes coming to Hugo.

@anthonyfok
Copy link
Member

Thank you @digitalcraftsman!
Thank you @mehedi-sharif!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants