Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase react-native-xcode.sh off [email protected] #74

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Rebase react-native-xcode.sh off [email protected] #74

merged 1 commit into from
Jul 23, 2019

Conversation

yenbekbay
Copy link
Contributor

@yenbekbay yenbekbay commented Jul 7, 2019

Description of changes

I was getting the following error while trying to build the bundle with the current react-native-xcode.sh script:

Screen Shot 2019-07-07 at 16 16 02

After some debugging, I found the cause to be the fact that metro config in [email protected] doesn't define ios as a valid platform by default.

In a normal setup, this wouldn't be a problem because ios is picked up automatically in the root of an RN project. However, my project had a script called react-native-bundle.sh in /ios/Build-Phases and performing cd .. changed the current directory to /ios as opposed to /.

The updated react-native-xcode.sh avoids that problem by using an absolute path for changing the current directory.

Related issues (if any)

#57 might possibly be addressed because you can know override the entry file by using the ENTRY_FILE environment variable.

@thekevinbrown
Copy link
Owner

Thanks so much for doing this. I don't currently have a v60 project I can test with, so I can't test this much without a lot of setup.

I'll go ahead and release this on a v3.0.0alpha version number so others can give it a go on their projects easily.

@thekevinbrown thekevinbrown merged commit 36422e8 into thekevinbrown:master Jul 23, 2019
@yenbekbay yenbekbay deleted the fix/react-native-v0.60.0 branch July 23, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants