Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I was getting the following error while trying to build the bundle with the current
react-native-xcode.sh
script:After some debugging, I found the cause to be the fact that metro config in [email protected] doesn't define
ios
as a valid platform by default.In a normal setup, this wouldn't be a problem because
ios
is picked up automatically in the root of an RN project. However, my project had a script calledreact-native-bundle.sh
in/ios/Build-Phases
and performingcd ..
changed the current directory to/ios
as opposed to/
.The updated
react-native-xcode.sh
avoids that problem by using an absolute path for changing the current directory.Related issues (if any)
#57 might possibly be addressed because you can know override the entry file by using the
ENTRY_FILE
environment variable.