-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It would be nice to be able to pass parameters to react-native-xcode.sh #57
Comments
I'm not particularly familiar with how this works, as I haven't used it before. In the vanilla version, do you edit the script step in XCode to accomplish this, or? Could you provide me with an example of what you're trying to accomplish? |
Yep, I edit the script step. If you check out the
So the build phase step could look like this: |
@synackal, correct me if I'm wrong, but isn't that use case already catered for in the |
And you mean to pass 'nodeCommand' with a path to your existing script with the extra parameter in that settings object? Or is there an easier way? Heh, part of this request is exploratory because I wasn't sure if it was already covered by your current functionality and whether that would be the best way to handle it, i.e., isn't fragile across versions. |
I'm talking about the stuff under the
Does that do what you need? If not, can you give me an example of what you're trying to achieve in terms of your project (not the steps to get there)? |
I do not think either of our suggestions will work: (1) Modify/Add the node command within the settings option The reason why (1) doesn't work is because that modification doesn't replace the existing invocation of your The reason why (2) doesn't work is that because in What I need to have happen (and what I am currently using as a work-around) is in my Xcode build phases I replace your
but by doing this I can't take advantage of having the fix-script being invoked and possibly missing potential additional behavior you may add in the future. To answer you stated question, my goal is to bundle my JS code and assets from a different path and name than the default in the main script. Apologies for taking a little while in getting back to you and also if I've missed anything outstandingly obvious. |
Ah, I got what you're tying to do now. The best way to do it would be to have a configuration option in |
Steps to reproduce the behavior
react-native-xcode.sh
in thereact
package allows for the passing of parameters, e.g., path to index.js for ENTRY_FILE.Expected behavior
Developer should be able to specify parameters.
Actual behavior
No option available.
The text was updated successfully, but these errors were encountered: