Update to gha-puppet v3 & voxpupuli-test 9.x & Replace legacy facts in rspec tests #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Very odd, this passes locally for me 🤔 I will dig around a bit. |
bastelfreak
added a commit
to bastelfreak/puppet-puppet
that referenced
this pull request
Mar 5, 2025
This was a workaround for legacy facter versions. The factsets in facterdb, for FreeBSD 11 & 12, all contain the ruby hash. Removing this workaround removes a legacy fact, which makes the upgrade in theforeman#929 easier.
bastelfreak
force-pushed
the
gha-puppet-v3
branch
from
f2d4028 to
1ed096d
Compare
Member
Author
|
Also contains #930 |
ekohl
pushed a commit
that referenced
this pull request
Mar 5, 2025
This was a workaround for legacy facter versions. The factsets in facterdb, for FreeBSD 11 & 12, all contain the ruby hash. Removing this workaround removes a legacy fact, which makes the upgrade in #929 easier.
bastelfreak
force-pushed
the
gha-puppet-v3
branch
5 times, most recently
from
e0fa9c2 to
0687b58
Compare
ekohl
approved these changes
Mar 5, 2025
This was referenced Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.