Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 test not running #80

Closed
johnistan opened this issue Feb 1, 2016 · 4 comments
Closed

Python 3 test not running #80

johnistan opened this issue Feb 1, 2016 · 4 comments

Comments

@johnistan
Copy link

I don't think the .travis.yml is setup correctly to run python3 tests. I am hitting some python3 errors.

py27 and py34 are declared as dependencies and travis is correctly but the tox.ini is hard coding py2.7

Here is the log from the last stable travis run:

source ~/virtualenv/python3.4/bin/activate
$ python --version
Python 3.4.2  <-------CORRECT
$ pip --version
pip 6.0.7 from /home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages (python 3.4)
install
1.67s$ pip install tox
You are using pip version 6.0.7, however version 7.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Collecting tox
  Downloading tox-2.2.1-py2.py3-none-any.whl
Collecting pluggy<0.4.0,>=0.3.0 (from tox)
  Downloading pluggy-0.3.1-py2.py3-none-any.whl
Collecting virtualenv>=1.11.2 (from tox)
  Downloading virtualenv-13.1.2-py2.py3-none-any.whl (1.7MB)
    100% |################################| 1.7MB 172kB/s 
Requirement already satisfied (use --upgrade to upgrade): py>=1.4.17 in /home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages (from tox)
Installing collected packages: virtualenv, pluggy, tox
Successfully installed pluggy-0.3.1 tox-2.2.1 virtualenv-13.1.2
8.51s$ make test
tox
py create: /home/travis/build/thefactory/marathon-python/.tox/py
py installdeps: -rrequirements.txt, pytest, mock
py develop-inst: /home/travis/build/thefactory/marathon-python
py installed: funcsigs==0.4,-e git+https://github.com/thefactory/marathon-python.git@a246bb2473e5dd1aa7775aade59cdf96f80e1d45#egg=marathon-dev,mock==1.3.0,pbr==1.8.1,py==1.4.31,pytest==2.8.4,requests==2.8.1,requests-mock==0.7.0,six==1.10.0,wheel==0.24.0
py runtests: PYTHONHASHSEED='3066453394'
py runtests: commands[0] | py.test -s tests
============================= test session starts ==============================
platform linux2 -- Python 2.7.9, pytest-2.8.4, py-1.4.31, pluggy-0.3.1  <-------NOT CORRECT!!!!!
rootdir: /home/travis/build/thefactory/marathon-python, inifile: 
collected 3 items 
tests/test_api.py ...

This is the issue i think: https://github.com/thefactory/marathon-python/blob/master/tox.ini#L9

@solarkennedy
Copy link
Contributor

Hmm. I had a hunch this was happening.
Even if you removed the tox line, would that be enough?

Looking at more complicated python+travis+tox setups, it looks like you have to pass in more things:
https://github.com/twisted/klein/blob/master/tox.ini
https://github.com/twisted/klein/blob/master/.travis.yml

And then not matrix on python: ?

Do you feel comfortable making a PR to fix?

@johnistan
Copy link
Author

i will put a pr in.

@yuywz
Copy link

yuywz commented Jun 24, 2016

Hi guys, is anyone working on this issue?
I want to use marathon-python in OpenStack [1] project, but according to the community policy, only the python 3 compatible libraries are allowed to be added to OpenStack dependency, please see the comments in this patch [2] for detail.
Can you please help to resolve this issue? Thanks in advance!

[1]http://www.openstack.org/
[2]https://review.openstack.org/#/c/333264/

@yuywz
Copy link

yuywz commented Jun 27, 2016

Hi @jofusa , are you still planning to work on the PR you mentioned in comment?
This issue is blocking us from using marathon-python in OpenStack, please see my last comment for detail. It'd be a big help if you could help to fix it, thanks!

tanaypf9 pushed a commit to tanaypf9/pf9-requirements that referenced this issue May 20, 2024
Patch Set 3:

Along with the py3 concerns, this bug is still open "Python 3 test not running":  thefactory/marathon-python#80

Patch-set: 3
Reviewer: Gerrit User 11805 <11805@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
tanaypf9 pushed a commit to tanaypf9/pf9-requirements that referenced this issue May 20, 2024
Patch Set 3:

Thanks folks!
I already left some comments on thefactory/marathon-python#80 to ask the maintainers of marathon-python to help on the python 3 issue. Still waiting for their response.

Patch-set: 3
tanaypf9 pushed a commit to tanaypf9/pf9-requirements that referenced this issue May 20, 2024
Patch Set 3: Workflow-1

Wait for the py3 issue in marathon-python to be fixed: thefactory/marathon-python#80

Patch-set: 3
Reviewer: Gerrit User 13248 <13248@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Workflow=-1
tanaypf9 pushed a commit to tanaypf9/pf9-requirements that referenced this issue May 20, 2024
Patch Set 4:

Hi all, the python3 issue[1] in marathon-python has been fixed, and the change has been included in version 0.8.6, see [2]. Please help to review, thanks!

[1]thefactory/marathon-python#80
[2]https://github.com/thefactory/marathon-python/blob/master/CHANGELOG.md

Patch-set: 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants