Fix py3k regression in 0.8.3 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.items() works in both. This dictionary won't ever be especially large, so the performance hit for not using an iterator in py27 is negligible.
|
If this is good to go, can we get a 0.8.4 as well? Thanks. |
|
Looks fine, the tests are passing. If you are interested in python 3 compat you might be interested in #80 because I think we are not running python3 tests... :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.items() works in both. This dictionary won't ever be especially large,
so the performance hit for not using an iterator in py27 is negligible.
If you really want, I can pull in
six.iteritems()but I didn't see any other uses ofsixso I didn't want to introduce a new dependency.