-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Right-To-Left languages #532
Conversation
✅ Deploy Preview for gohugo-ananke-theme-demo canceled.
|
Hi @MeirKriheli this looks great thank you! Do you have a repo with a language where this would apply? I'm curious to test it against the default |
I'd rather not have to many languages in there, but I have my own sandbox where I stress test the theme with some edge cases, if you could share some hebrew md files with me, that would be great! Thanks |
Here's the WIP of the website I'm working on: |
Hi @MeirKriheli thanks for sharing this repo. I realize the As a result running a previous version,
The latter is great as updating the language direction evaluation logic will be very easy to update in the future. Let me know if you need any pointer for the function but I guess Thanks! |
@regisphilibert added |
Thanks a lot, I revisited your logic a tiny bit without notifying you as was in a the middle of publishing a release and felt this had to be part of it. I made the dir attribute only added if the languageDirection is explicitly set, so no user gets any surprise. c49009b Thanks a lot for your work! |
* Added support for Right-To-Left languages * Added language-direction partial
No description provided.