Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minVersion from 0.64.0 to 0.84.0 #541

Closed
regisphilibert opened this issue Apr 11, 2022 · 0 comments · Fixed by #543
Closed

Bump minVersion from 0.64.0 to 0.84.0 #541

regisphilibert opened this issue Apr 11, 2022 · 0 comments · Fixed by #543
Assignees
@regisphilibert

Comments

@regisphilibert
Copy link
Member

regisphilibert commented Apr 11, 2022 •
edited
Loading

Bumping minimum version is not a light decision, especially of such a big leap.

But as we want to keep the theme supporting older versions, we need to be able to secure new features behind version conditionals.

While we can test hugo version with {{ if ge hugo.Version "0.70.0" }} since 0.63.0, testing if user is using Hugo extended which allows sass and webp image processing is only possible since 0.83.0 with hugo.IsExtended. (see #452)

Also 0.84.0 allows to id error messages which is very useful for themes.

I feel with a min version of 84 we'll be more confortable using Hugo's latest features while maintaining cross compatibility of the theme users.
@regisphilibert regisphilibert self-assigned this Apr 11, 2022
@regisphilibert regisphilibert mentioned this issue Apr 12, 2022
Merged
regisphilibert added a commit that referenced this issue Apr 21, 2022
@regisphilibert
Upgrade "minVersion" of theme to 84
872d041 
Check hugo.IsExtended before trying to process scss files

Fixes #541
@regisphilibert regisphilibert mentioned this issue Apr 21, 2022
Merged
regisphilibert added a commit that referenced this issue Apr 21, 2022
@regisphilibert
Upgrade "minVersion" of theme to 84 (#543)
751ac93 
* Upgrade "minVersion" of theme to 84

Check hugo.IsExtended before trying to process scss files

Fixes #541
tstephen pushed a commit to tstephen/gohugo-theme-ananke that referenced this issue Jun 9, 2022
@regisphilibert @tstephen
Upgrade "minVersion" of theme to 84 (theNewDynamic#543)
9846724 
* Upgrade "minVersion" of theme to 84

Check hugo.IsExtended before trying to process scss files

Fixes theNewDynamic#541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@regisphilibert regisphilibert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade "minVersion" of theme to 84 theNewDynamic/gohugo-theme-ananke
1 participant
@regisphilibert