*: update Prometheus / promql-engine dependency with fix + add test case for pushed down subquery#5602
*: update Prometheus / promql-engine dependency with fix + add test case for pushed down subquery#5602GiedriusS wants to merge 4 commits intothanos-io:mainfrom
Conversation
3cb008a to
9f554ed
Compare
go.mod
Outdated
| // Required by Cortex https://github.com/cortexproject/cortex/pull/3051. | ||
| github.com/bradfitz/gomemcache => github.com/themihai/gomemcache v0.0.0-20180902122335-24332e2d58ab | ||
|
|
||
| github.com/prometheus/prometheus => github.com/vinted/prometheus v1.8.2-0.20220817132046-4af7e615cfb4 |
There was a problem hiding this comment.
Temporary fork until prometheus/prometheus#11163 is figured out.
fpetkovski
left a comment
There was a problem hiding this comment.
Thanks, lgtm.
We can also wait a few days see if your upstream patch gets merged in Prometheus.
Repro for thanos-io#5600. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
9f554ed to
84d22a1
Compare
Update prometheus dependency. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
fb6f97f to
b98f5ae
Compare
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
321f67d to
681a9a1
Compare
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
|
Hm, is the test failure relevant? |
Yeah, something went wrong. Looking into it |
|
This contains the new OOO samples feature in TSDB? |
|
FYI Prometheus has tagged |
|
Feel free to update it in a separate PR as I'll be on vacation for a bit |
|
Looks like this is the culprit, because of change here https://github.com/jesusvazquez/prometheus/blob/c785aa0b69c2aab6966209f91d5294fb993e979e/tsdb/wal/wal.go#L282 coming from prometheus/prometheus#11075: |
Repro for #5600.
Signed-off-by: Giedrius Statkevičius giedrius.statkevicius@vinted.com