Switch to use Miekg by default #4519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Contributor
Author
|
/retest |
GiedriusS
previously approved these changes
Aug 4, 2021
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
I have personally encountered problems with the Go DNS resolver as well - it was resolving some of the records but not all of them. Switching to miekgdns had helped me. So, I agree with this PR 👍
CHANGELOG.md
Outdated
|
|
||
| - [#4468](https://github.com/thanos-io/thanos/pull/4468) Rule: Fix temporary rule filename composition issue. | ||
| - [#4476](https://github.com/thanos-io/thanos/pull/4476) UI: fix incorrect html escape sequence used for '>' symbol. | ||
| - [#4519](https://github.com/thanos-io/thanos/pull/4519) Store: fix cannot unmarshal DNS message errors. |
Member
There was a problem hiding this comment.
I would probably write Query: switch to miekgdns DNS resolver as the default one under the Changed section instead 😄
Signed-off-by: clyang82 <[email protected]>
Contributor
Author
|
/retest |
3 tasks
2 tasks
squat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Related to issue: #4204 Problem: in the PR #4519 the default sd-dns-resolver for querier was set to miekgdns but this change was never ported to ruler Solution: this PR brings this default to ruler as well to make it consistent Signed-off-by: JoaoBraveCoding <[email protected]> Signed-off-by: JoaoBraveCoding <[email protected]>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Related to issue: thanos-io#4204 Problem: in the PR thanos-io#4519 the default sd-dns-resolver for querier was set to miekgdns but this change was never ported to ruler Solution: this PR brings this default to ruler as well to make it consistent Signed-off-by: JoaoBraveCoding <[email protected]> Signed-off-by: JoaoBraveCoding <[email protected]>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Related to issue: thanos-io#4204 Problem: in the PR thanos-io#4519 the default sd-dns-resolver for querier was set to miekgdns but this change was never ported to ruler Solution: this PR brings this default to ruler as well to make it consistent Signed-off-by: JoaoBraveCoding <[email protected]> Signed-off-by: JoaoBraveCoding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: clyang82 [email protected]
Changes
ref: #4204
I saw the same issue exists in version 0.22 in OCP 4.8.
If I understand correctly,
Miekg resolver was working fine for everyone, but Go native not. so have this PR to use Miekg as default resolver.Verification