Skip to content

Commit 0e9cc46

Browse files
authored
Switch to use Miekg by default (#4519)
* Switch to use Miekg by default Signed-off-by: clyang82 <[email protected]> * Update changelog.md Signed-off-by: clyang82 <[email protected]> * Address review comments Signed-off-by: clyang82 <[email protected]>
1 parent 0536ba6 commit 0e9cc46

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
2222
- [#4476](https://github.com/thanos-io/thanos/pull/4476) UI: fix incorrect html escape sequence used for '>' symbol.
2323

2424
### Changed
25+
- [#4519](https://github.com/thanos-io/thanos/pull/4519) Query: switch to miekgdns DNS resolver as the default one.
2526

2627
## [v0.22.0](https://github.com/thanos-io/thanos/tree/release-0.22) - 2021.07.22
2728

cmd/thanos/query.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ func registerQuery(app *extkingpin.App) {
127127
Default("30s"))
128128

129129
dnsSDResolver := cmd.Flag("store.sd-dns-resolver", fmt.Sprintf("Resolver to use. Possible options: [%s, %s]", dns.GolangResolverType, dns.MiekgdnsResolverType)).
130-
Default(string(dns.GolangResolverType)).Hidden().String()
130+
Default(string(dns.MiekgdnsResolverType)).Hidden().String()
131131

132132
unhealthyStoreTimeout := extkingpin.ModelDuration(cmd.Flag("store.unhealthy-timeout", "Timeout before an unhealthy store is cleaned from the store UI page.").Default("5m"))
133133

pkg/cacheutil/memcached_client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ func newMemcachedClient(
247247
addressProvider = dns.NewProvider(
248248
logger,
249249
extprom.WrapRegistererWithPrefix("thanos_memcached_", reg),
250-
dns.GolangResolverType,
250+
dns.MiekgdnsResolverType,
251251
)
252252
}
253253

0 commit comments

Comments
 (0)