Fix bugs to ignore Capital letter at the beginning of the Sentence

[donganzh-zz]

Hi, @azu
As I was using this rule on my documents, I found a bug that if there is a capital letter at the beginning of the sentence and there is an explanation to an acronym right after it, the rule won't extract the right acronym for the comparison. Here is an example:

In the Amazon Web Service, it can be short as AWS.

In this case, previously the rule will extract IAWS to compare with AWS because "the" is an acronymJoiningWords, which generates an error message.

In order to fix it, I first reverse the AcronymCreater array and loop using reduce and add the first character to beginning on every iteration and finally join on every iteration and push to result array

{"S", "WS", "AWS", "IAWS"}

Then check this array using isWordSatidfy method and push the good ones to expandedAcronymList to compare with AWS.

I added this test case in the textlint-rule-unexpanded-acronym-test.js and it passed all the previous test as well.

I also update the array-includes package to the latest version.

Cheers!

[azu]

Can you add test case for this bug?
We want to prevent regression.

[azu]

It is good interface that always return an array.

return [expandOneWordToAcronym(words[0]))

This change will remove unnessary Array.isArray code from https://github.com/textlint-rule/textlint-rule-unexpanded-acronym/pull/6/files#diff-8c133963a70d07eee0bd3b0a4e71f38eR72

                    var acronyms = acronymCreator.extractAcronym();
-                    //if the acronyms is a string i.e. only one acronym
-                    if(!Array.isArray(acronyms)){
-                        if (isWordSatisfy(acronyms)) {
-                            expandedAcronymList.push(acronyms);
-                        }
-                    //if the acronyms is an array of acronym, we need - to extract the satisfied ones
-                    }else{
                        acronyms.forEach(acronym => {
                            if (isWordSatisfy(acronym)) {
                                expandedAcronymList.push(acronym);
                            }
                        });
-                    }

[azu]

It is not JSDoc.

Suggested change

	* @param words (array)
	* @param {string[]} words

[donganzh-zz]

Changes fixed

[donganzh-zz]

@azu hello, could you please review my changes? thanks

[parkas2018]

I have the following sentence where the acronym "AWS" is being reported as unexpanded. Will this PR fix this issue?

This topic describes the process to setup this tool, which you can use for deploying the application on either Azure or Amazon Web Services (AWS)

[amimas]

Hello, any update on this PR?

[azu]

LGTM.

Sorry to delay.

[azu]

I've published https://github.com/textlint-rule/textlint-rule-unexpanded-acronym/releases/tag/1.2.4