Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalized words (i.e. The) from Ignored list causes validation to fail #8

Closed
amimas opened this issue Apr 27, 2020 · 3 comments
Closed
Labels
Status: Proposal Request for comments Type: Bug Bug or Bug fixes

Comments

@amimas
Copy link

amimas commented Apr 27, 2020

The following line fails the validation by this linter:

| `verification_value` | Required | `string` | The Card Verification Value (CVV) code from the back of the card |

Even though the acronym is expanded, it still is reported as an unexpanded acronym because the rule is comparing CVV to TCVV

If I change the above snippet of content to either one of these lines, the content passes the validation:

| `verification_value` | Required | `string` | Card Verification Value (CVV) code from the back of the card |
| `verification_value` | Required | `string` | This is Card Verification Value (CVV) code from the back of the card |

Not sure if this issue is related to PR #6

@azu azu added Status: Proposal Request for comments Type: Bug Bug or Bug fixes labels Apr 29, 2020
@azu
Copy link
Member

azu commented Apr 29, 2020

A, An, The are special words.
Anything else?

Probably, we need to ignore A, An, and The in this step.
❓ We also need to check the word is at first in the sentence?

} else if (isCapitalized(word)) {
// Add temporarySequence
// => add temp [Aword, Bword, Cword] = ABC
acronymCreator.addWord(word);
} else if (

As a result,

  • The Card Verification Value -> CVV
  • An American Company -> AC
  • The A Word Word -> AWW ? (I dont have that pattern)

What do you think about it?

@amimas
Copy link
Author

amimas commented May 7, 2020

I just tried the latest version that was released in PR #6 and that fixed the issue I posted in the original message.

I think we can close this as fixed. What do you think?

@azu
Copy link
Member

azu commented May 11, 2020

ok

@azu azu closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Proposal Request for comments Type: Bug Bug or Bug fixes
Projects
None yet
Development

No branches or pull requests

2 participants