fix(base-cluster/ingress): disable traefik apiCheck

[cwrau]

Otherwise this fails during test-templating

Summary by CodeRabbit

• Chores
  • Added configuration option to disable API checks for Prometheus service monitor integration in Traefik.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[gemini-code-assist]

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a templating failure within the base-cluster/ingress chart by modifying the Traefik Prometheus configuration. The change explicitly disables an API check, ensuring that the chart can be successfully templated without errors, which is crucial for deployment and testing processes.

Highlights

• Traefik Prometheus Configuration: Disabled the disableAPICheck setting for Traefik's Prometheus metrics to prevent failures during test-templating.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

📝 Walkthrough

Walkthrough

A single configuration flag disableAPICheck: true is added to the Traefik HelmRelease's Prometheus service monitor integration within the base-cluster chart. This allows the API check to be disabled during Prometheus metrics collection without modifying any other existing behavior.

Changes

Cohort / File(s)	Summary
Traefik Prometheus Configuration charts/base-cluster/templates/ingress/traefik.yaml	Added disableAPICheck: true flag under prometheus.serviceMonitor to disable API check validation during metrics collection

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• fix(base-cluster/ingress): add missing prometheus block 🙄 #1767: Modifies the Traefik HelmRelease's prometheus metrics configuration in the same file, providing related context for this API check flag addition.

Suggested labels

base-cluster

Suggested reviewers

• tasches
• teutonet-bot
• marvinWolff

Poem

🐰 A flag so small, yet oh so fine,
disableAPICheck, a simple line,
Prometheus won't validate today,
In Traefik's config, it has its way! 🎯

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(base-cluster/ingress): disable traefik apiCheck' clearly and concisely describes the main change—disabling the Traefik apiCheck flag in the ingress configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 85ae79f and e994f54.

📒 Files selected for processing (1)

• charts/base-cluster/templates/ingress/traefik.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: check licenses
• GitHub Check: Agent
• GitHub Check: lint helm chart (base-cluster)
• GitHub Check: wait-for-checks

🔇 Additional comments (1)

charts/base-cluster/templates/ingress/traefik.yaml (1)

64-70: LGTM - Appropriate fix for test-templating scenarios.

Disabling the API check prevents template rendering failures when Prometheus Operator CRDs aren't available during helm template testing. The dependsOn constraint still ensures the actual runtime dependency on kube-prometheus-stack when Prometheus monitoring is enabled.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request addresses a test-templating failure in the Traefik ingress controller by setting disableAPICheck: true. The provided comment suggests making this setting configurable, aligning with Helm chart best practices for greater flexibility across environments, while maintaining the immediate fix for testing.

[Copilot]

Pull request overview

This PR fixes a test-templating failure in the Traefik ingress controller configuration by disabling the Prometheus API check during Helm chart rendering.

Changes:

• Added disableAPICheck: true to Traefik's Prometheus metrics configuration to prevent API availability checks during template rendering

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.