Skip to content

fix(base-cluster/tracing): use correct resources for tracing gateway #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cwrau merged 1 commit into from
Nov 28, 2025
Merged

fix(base-cluster/tracing): use correct resources for tracing gateway #1832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/base-cluster/templates/monitoring/alloy-gateway.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:
{{- end }}
alloy:
enableReporting: false
resources: {{- include "common.resources" .Values.monitoring.loki.promtail | nindent 8 }}
resources: {{- include "common.resources" .Values.monitoring.alloy.gateway | nindent 8 }}
{{- if .Values.monitoring.loki.enabled }}
mounts:
varlog: true
Expand Down
18 changes: 17 additions & 1 deletion charts/base-cluster/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,11 @@
"type": "string",
"pattern": "[0-9]+(ms|s|m|h|d|w|y)",
"description": "Loki log retention period (e.g., 45d, 7d, 24h)",
"examples": ["45d", "7d", "24h"]
"examples": [
"45d",
"7d",
"24h"
]
Comment on lines +928 to +932
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reformatting of the examples array from inline to multi-line is inconsistent with the PR's stated purpose of fixing tracing gateway resources. This stylistic change should be avoided as it adds noise to the diff without providing functional value. If code formatting changes are desired, they should be done in a separate PR focused on formatting.

Suggested change
"examples": [
"45d",
"7d",
"24h"
]
"examples": ["45d", "7d", "24h"]

Copilot uses AI. Check for mistakes.
},
"persistence": {
"type": "object",
Expand Down Expand Up @@ -956,6 +960,18 @@
},
"resources": {
"$ref": "#/$defs/resourceRequirements"
},
"gateway": {
"type": "object",
"properties": {
"resourcesPreset": {
"$ref": "#/$defs/resourcesPreset"
},
"resources": {
"$ref": "#/$defs/resourceRequirements"
}
},
"additionalProperties": false
}
},
"additionalProperties": false
Expand Down
2 changes: 2 additions & 0 deletions charts/base-cluster/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,8 @@ monitoring:
limits:
cpu: 1
memory: 128Mi
gateway:
resourcesPreset: small
metricsServer:
enabled: true
securityScanning:
Expand Down
Loading