fix(base-cluster/tracing): use correct resources for tracing gateway

[cwrau]

Summary by CodeRabbit

Release Notes

• New Features

  • Added configurable resource presets for monitoring gateway components, enabling better control over infrastructure resource allocation.

• Configuration

  • Updated schema to support gateway resource configuration options with preset and custom resource definitions.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[gemini-code-assist]

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the Alloy tracing gateway was incorrectly configured to use Promtail's resource definitions. It introduces a dedicated schema and default values for the Alloy gateway's resources, ensuring proper and independent resource allocation for this component within the base cluster's monitoring setup. This change enhances the clarity and correctness of resource management for the tracing infrastructure.

Highlights

• Resource Allocation Correction: The Alloy tracing gateway now correctly references its own dedicated resource configuration (.Values.monitoring.alloy.gateway) instead of inadvertently using Promtail's resource settings (.Values.monitoring.loki.promtail).
• Schema Definition for Gateway Resources: A new gateway object has been added under monitoring.alloy in the values.schema.json, providing a structured definition for configuring the Alloy gateway's resourcesPreset and resources.
• Default Gateway Resource Preset: A default resourcesPreset of small has been introduced for the Alloy gateway within the monitoring.alloy section of values.yaml, ensuring a baseline resource configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the Helm chart configuration for the alloy gateway component by introducing a new gateway resource property under both the loki and alloy monitoring sections. The changes redirect resource allocation from monitoring.loki.promtail to monitoring.alloy.gateway, with corresponding schema and values definitions.

Changes

Cohort / File(s)	Summary
Template & Schema Updates charts/base-cluster/templates/monitoring/alloy-gateway.yaml, charts/base-cluster/values.schema.json	Updated HelmRelease resource references to use .Values.monitoring.alloy.gateway instead of .Values.monitoring.loki.promtail. Added new gateway property definitions to both loki and alloy objects in schema with resourcesPreset and resources references.
Values Configuration charts/base-cluster/values.yaml	Added gateway.resourcesPreset: small configuration under monitoring sections for both Loki and Alloy components.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Straightforward configuration and schema additions following a consistent pattern
• Changes are homogeneous (repeating the same gateway property structure in two places)
• Verify schema definitions match expected resource requirement references

Possibly related PRs

• fix(base-cluster): migrate promtail leftovers to alloy #1720: Modifies the same resource migration path from monitoring.loki.promtail to monitoring.alloy with schema and values updates
• feat(base-cluster/tracing): add gateway to enable tail sampling #1736: Adds telemetry-gateway HelmRelease configuration and alloy.gateway settings in related monitoring templates

Suggested labels

base-cluster

Suggested reviewers

• tasches
• marvinWolff
• teutonet-bot

Poem

🐰 A gateway springs to life today,
With alloy resources in perfect array,
No more promtail, the old way fades,
Fresh schema fields in neat cascades,
Small presets now for monitoring's delight! 🎉

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/base-cluster/tracing-gateway-resources

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3fbe3cf and 954998c.

📒 Files selected for processing (3)

• charts/base-cluster/templates/monitoring/alloy-gateway.yaml (1 hunks)
• charts/base-cluster/values.schema.json (2 hunks)
• charts/base-cluster/values.yaml (1 hunks)

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug where the tracing gateway was not being assigned any resource requests or limits due to an incorrect path in the Helm template. The change in alloy-gateway.yaml now correctly points to .Values.monitoring.alloy.gateway for its resource configuration. This is properly supported by the addition of the gateway object to the schema in values.schema.json and the corresponding default values in values.yaml. The changes are consistent and well-executed, and I have no further suggestions for improvement.

[Copilot]

Pull request overview

This PR fixes a resource configuration bug in the tracing gateway component. The alloy-gateway template was incorrectly referencing non-existent Loki promtail resources instead of the proper alloy gateway resources configuration.

Key changes:

• Adds new gateway configuration under monitoring.alloy with resourcesPreset: small
• Updates JSON schema to validate the new gateway configuration structure
• Fixes template to reference correct resources path: .Values.monitoring.alloy.gateway instead of .Values.monitoring.loki.promtail

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
charts/base-cluster/values.yaml	Adds gateway.resourcesPreset configuration under monitoring.alloy
charts/base-cluster/values.schema.json	Defines JSON schema validation for the new gateway configuration object
charts/base-cluster/templates/monitoring/alloy-gateway.yaml	Fixes resource reference from non-existent loki.promtail to correct alloy.gateway path

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The reformatting of the examples array from inline to multi-line is inconsistent with the PR's stated purpose of fixing tracing gateway resources. This stylistic change should be avoided as it adds noise to the diff without providing functional value. If code formatting changes are desired, they should be done in a separate PR focused on formatting.

Suggested change

	"examples": [
	"45d",
	"7d",
	"24h"
	]
	"examples": ["45d", "7d", "24h"]