Skip to content

fix(base-cluster/monitoring): use the correct prometheus datasource id#1764

Merged
cwrau merged 1 commit intomainfrom
fix/base-cluster/prometheus-datasource-id
Oct 24, 2025
Merged

fix(base-cluster/monitoring): use the correct prometheus datasource id#1764
cwrau merged 1 commit intomainfrom
fix/base-cluster/prometheus-datasource-id

Conversation

@cwrau
Copy link
Copy Markdown
Member

@cwrau cwrau commented Oct 24, 2025

Summary by CodeRabbit

  • Chores
    • Updated Grafana dashboard configuration for improved data source compatibility.

Copilot AI review requested due to automatic review settings October 24, 2025 08:13
@cwrau cwrau enabled auto-merge October 24, 2025 08:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the Prometheus datasource identifier in the Grafana dashboard configuration to use the correct lowercase value.

Key Changes:

  • Updated the datasource reference from "Prometheus" to "prometheus" in the kubernetes-cluster-monitoring-via-prometheus dashboard configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 24, 2025

Walkthrough

A single Grafana dashboard data source reference in the Kubernetes cluster monitoring configuration was updated from uppercase "Prometheus" to lowercase "prometheus" for consistency with the actual data source naming convention.

Changes

Cohort / File(s) Change Summary
Grafana Configuration
charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml
Normalized Grafana dashboard data source name for kubernetes-cluster-monitoring-via-prometheus from "Prometheus" to "prometheus" (lowercase)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

base-cluster

Suggested reviewers

  • marvinWolff
  • tasches
  • teutonet-bot

Poem

🐰 A whisker of a change, so small and neat,
Prometheus now lowercase—oh how sweet!
Case sensitivity fixed with care,
The monitoring stack's beyond compare!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "fix(base-cluster/monitoring): use the correct prometheus datasource id" directly and accurately reflects the main change in the pull request. The changeset modifies a Grafana dashboard configuration to update the datasource from "Prometheus" (uppercase) to "prometheus" (lowercase), which is precisely what the title describes. The title is specific, concise, uses conventional commit format, and avoids vague terminology or noise. It provides sufficient context for a developer scanning the history to understand that this is a correction to the datasource identifier in the monitoring configuration.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/base-cluster/prometheus-datasource-id

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a4c774 and ef74153.

📒 Files selected for processing (1)
  • charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: check licenses
  • GitHub Check: Update release-please config file for a possibly new chart
  • GitHub Check: lint helm chart (base-cluster)
🔇 Additional comments (2)
charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml (2)

115-116: Change is correct: datasource ID matches kube-prometheus-stack convention.

The modification updates the datasource reference from uppercase "Prometheus" to lowercase "prometheus" to align with the actual datasource uid used in kube-prometheus-stack's ConfigMap generation. Due to the YAML anchor on line 115 (&dashboard), this change cascades to all dashboards that use the anchor (lines 120, 123, 127, 131, 136, 141, 145, 150, 157, 164, 170, 176, 182), ensuring consistent datasource references across all imported dashboards.

No additional updates are needed; the change is complete and correct.


1-210: Check for other uppercase "Prometheus" datasource references in related files.

While this file is updated, verify there are no inconsistencies in other Grafana dashboard or datasource provisioning files that might still reference uppercase "Prometheus".


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cwrau cwrau added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 511cc84 Oct 24, 2025
32 of 33 checks passed
@cwrau cwrau deleted the fix/base-cluster/prometheus-datasource-id branch October 24, 2025 10:46
github-merge-queue Bot pushed a commit that referenced this pull request Oct 27, 2025
🤖 I have created a release *beep* *boop*
---


##
[10.0.1](base-cluster-v10.0.0...base-cluster-v10.0.1)
(2025-10-27)


### Bug Fixes

* **base-cluster/descheduler:** don't remove pods with too many restarts
([#1744](#1744))
([9c1ed51](9c1ed51))
* **base-cluster/ingress:** add missing `prometheus` block 🙄
([#1767](#1767))
([a329e1a](a329e1a))
* **base-cluster/loki:** adjust retention settings for loki logs
([#1745](#1745))
([1985d34](1985d34))
* **base-cluster/monitoring:** use the correct prometheus datasource id
([#1764](#1764))
([511cc84](511cc84))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Fixed descheduler to prevent removal of pods with excessive restart
counts
  * Added missing Prometheus monitoring configuration to ingress
  * Adjusted log retention settings in Loki
  * Corrected Prometheus datasource ID in monitoring

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants