fix(base-cluster/descheduler): don't remove pods with too many restarts

[cwrau]

Otherwise the prometheus alerts don't fire, as they never get too old.
Combined with pods that take a little while to crash and are ready
before that, not even KubeDeploymentReplicasMismatch triggers.
This effectively hides that error.

Summary by CodeRabbit

• Chores
  • Removed the RemovePodsHavingTooManyRestarts policy from the base cluster descheduler configuration, including its associated pod restart threshold parameters and all related plugin list entries. This configuration change updates how the cluster manages pod eviction and rescheduling, specifically modifying the handling of pods that experience frequent restarts.

[coderabbitai]

Walkthrough

The descheduler plugin configuration in the Helm values file has been updated to remove the RemovePodsHavingTooManyRestarts plugin entry, including its DefaultEvictor arguments and podRestartThreshold setting, as well as its entry in the enabled plugins list.

Changes

Cohort / File(s)	Summary
Descheduler plugin config cleanup charts/base-cluster/values.yaml	Removed RemovePodsHavingTooManyRestarts plugin configuration block from DefaultEvictor args, including podRestartThreshold argument, and removed the plugin from the enabled plugins list

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A plugin bids farewell today,
No more restarts get in the way,
The config grows lean and clean,
Simplest Helm change we've seen! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "fix(base-cluster/descheduler): don't remove pods with too many restarts" directly and accurately describes the primary change in the changeset. The title clearly indicates that the modification prevents the descheduler from removing pods that have experienced many restarts, which aligns perfectly with the raw summary showing that the RemovePodsHavingTooManyRestarts plugin configuration has been removed. The title is concise, uses conventional commit formatting, avoids vague terms, and provides sufficient clarity for a reviewer scanning the project history to understand the intent of the change.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/base-cluster/descheduler-dont-remove-pods-with-too-many-restarts

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b61010 and 4ceea80.

📒 Files selected for processing (1)

• charts/base-cluster/values.yaml (0 hunks)

💤 Files with no reviewable changes (1)

• charts/base-cluster/values.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: check licenses
• GitHub Check: Update release-please config file for a possibly new chart
• GitHub Check: lint helm chart (base-cluster)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull Request Overview

This PR adjusts the default descheduler behavior to avoid evicting pods with high restart counts so that Prometheus alerts can age and fire as intended.

• Remove the RemovePodsHavingTooManyRestarts strategy from the descheduler configuration
• Retain other descheduler strategies unchanged

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}