Skip to content

fix(base-cluster/kyverno): change kubectl image#1734

Merged
cwrau merged 2 commits intomainfrom
fix/kyverno-kubectl
Oct 15, 2025
Merged

fix(base-cluster/kyverno): change kubectl image#1734
cwrau merged 2 commits intomainfrom
fix/kyverno-kubectl

Conversation

@tasches
Copy link
Copy Markdown
Collaborator

@tasches tasches commented Oct 13, 2025

Summary by CodeRabbit

  • New Features

    • Enhanced Kyverno image configuration: when no global registry is set, you can now specify explicit repository and tag values, providing finer control over image selection and deployments.
  • Chores

    • Consolidated and cleaned up chart image annotations to reduce duplication and improve clarity in metadata listings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 13, 2025

Walkthrough

The Kyverno Helm template switches from a single registry string to a structured image object with repository and tag fallbacks. The Chart.yaml Artifact Hub image annotations are consolidated by removing duplicate kubectl entries and condensing comments, retaining a single bats entry with inline references.

Changes

Cohort / File(s) Summary of Changes
Kyverno Helm template image spec
charts/base-cluster/templates/kyverno/kyverno.yaml
Replaces single image.registry usage with structured image fields: registry derived from global defaults, plus explicit repository and tag from global.kubectl.image.* when global.imageRegistry is unset. Surrounding conditionals unchanged.
Artifact Hub image annotations
charts/base-cluster/Chart.yaml
Consolidates artifacthub.io/images entries: removes multiple bitnami/kubectl:1.32.3 lines; retains a single docker.io/bats/bats:v1.4.1 entry with inline comments referencing related YAML targets.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • marvinWolff
  • cwrau

Poem

A rabbit taps at charts with glee,
Refactors images, tidy as can be.
Kyverno’s tag, repository aligned—
Annotations trimmed, duplicates resigned.
Hop, hop! Templates neat and true,
New carrots for the CI stew. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely describes the primary change—updating the kubectl image for the kyverno component in the base-cluster chart—using a conventional commit style that makes the intent immediately clear.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/kyverno-kubectl

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c72480 and 143dea8.

📒 Files selected for processing (1)
  • charts/base-cluster/Chart.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • charts/base-cluster/Chart.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: check licenses
  • GitHub Check: lint helm chart (base-cluster)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51a42a2 and e496be4.

📒 Files selected for processing (1)
  • charts/base-cluster/templates/kyverno/kyverno.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: check licenses
  • GitHub Check: Update release-please config file for a possibly new chart
  • GitHub Check: lint helm chart (base-cluster)

Comment thread charts/base-cluster/templates/kyverno/kyverno.yaml
cwrau
cwrau previously approved these changes Oct 13, 2025
@tasches tasches force-pushed the fix/kyverno-kubectl branch from dad2bce to 143dea8 Compare October 15, 2025 08:10
@cwrau cwrau added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit cb42f26 Oct 15, 2025
31 of 34 checks passed
@cwrau cwrau deleted the fix/kyverno-kubectl branch October 15, 2025 08:22
github-merge-queue Bot pushed a commit that referenced this pull request Oct 23, 2025
🤖 I have created a release *beep* *boop*
---


##
[10.0.0](base-cluster-v9.4.0...base-cluster-v10.0.0)
(2025-10-23)


### ⚠ BREAKING CHANGES

* **base-cluster/backup:** add k8up provider
([#1751](#1751))

### Features

* **base-cluster/backup:** add k8up provider
([#1751](#1751))
([0f36225](0f36225))


### Bug Fixes

* **base-cluster/kyverno:** change kubectl image
([#1734](#1734))
([cb42f26](cb42f26))
* **base-cluster:** conditions must the `true`, not just truthy
([#1738](#1738))
([7f46f4e](7f46f4e))
* **base-cluster:** migrate promtail leftovers to alloy
([#1720](#1720))
([8b7d062](8b7d062))


### Miscellaneous Chores

* **base-cluster/external-dns:** migrate domainFilters syntax
([#1681](#1681))
([51a42a2](51a42a2))
* **base-cluster/kdave:** remove kdave
([#1724](#1724))
([723c049](723c049))
* **base-cluster/logs:** only delete volumes on deletion
([#1721](#1721))
([36b657a](36b657a))
* **base-cluster/logs:** optimize volume chown; this speeds up startup
([36b657a](36b657a))
* **base-cluster/traces:** delete tempo volumes on deletion
([#1722](#1722))
([0afce96](0afce96))
* **base-cluster:** use upstream kubectl image instead of rancher
([#1718](#1718))
([d4daf94](d4daf94))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Release Notes - Version 10.0.0

* **Breaking Changes**
* base-cluster/backup provider modifications require attention during
upgrade.

* **New Features**
  * base-cluster/backup enhancements.

* **Bug Fixes**
  * Kyverno configuration improvements.
  * kubectl image handling optimizations.
  * Boolean condition evaluation corrections.
  * Promtail migration cleanup.
  * Tempo volume deletion fixes.

* **Chores**
  * Infrastructure syntax and dependency updates.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants