chore(base-cluster/traces): delete tempo volumes on deletion

[cwrau]

Summary by CodeRabbit

• New Features

  • Added PVC retention policy for Grafana Tempo ingester to retain data during scaling and clean up on deletion, improving data durability and lifecycle management.

• Chores

  • Upgraded Grafana Tempo Distributed chart to v1.48.0 for the monitoring stack.

[Copilot]

Pull Request Overview

This PR updates the Tempo distributed chart version and configures persistent volume claim retention policies for traces storage. The change ensures that when the Tempo deployment is deleted, associated volumes are automatically cleaned up rather than persisting.

• Updated tempo-distributed chart version from 1.46.0 to 1.48.0
• Added PVC retention policy configuration to automatically delete volumes on deployment deletion

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
charts/base-cluster/values.yaml	Updated tempo-distributed chart version to 1.48.0
charts/base-cluster/templates/monitoring/tracing/grafana-tempo.yaml	Added PVC retention policy to delete volumes when deployment is deleted

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[coderabbitai]

Walkthrough

Updates Grafana Tempo configuration by adding persistentVolumeClaimRetentionPolicy for the ingester and bumps the tempo-distributed chart version from 1.46.0 to 1.48.0. Changes are limited to Helm template and values files for the base cluster.

Changes

Cohort / File(s)	Summary
Tempo ingester PVC retention policy charts/base-cluster/templates/monitoring/tracing/grafana-tempo.yaml	Adds persistentVolumeClaimRetentionPolicy to ingester with whenDeleted: Delete and whenScaled: Retain.
Tempo chart version bump charts/base-cluster/values.yaml	Updates Grafana Tempo chart version: tempo-distributed 1.46.0 → 1.48.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• chore(base-cluster/monitoring): migrate grafana-tempo away from bitnami #1605 — Similar modifications to Grafana Tempo HelmRelease/values and ingester persistence settings.
• feat(base-cluster/monitoring): allow upsizing tempo storage #1448 — Adjusts Grafana Tempo ingester persistence (size/schema), related to persistence configuration changes.

Suggested labels

base-cluster

Suggested reviewers

• tasches
• marvinWolff
• teutonet-bot

Poem

I thump my paws, deploy delight,
PVCs that linger right—
Delete on farewell, retain on scale,
Tempo drums a tidy tale.
Charts hop ahead, version bright,
Burrow’s clean, observability tight. 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly communicates that tempo volumes will be deleted on deletion, matching the addition of a persistentVolumeClaimRetentionPolicy with whenDeleted set to Delete, and concisely reflects the primary change in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/base-cluster/tempo-volume-deletion

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 104f986 and 0b05828.

📒 Files selected for processing (2)

• charts/base-cluster/templates/monitoring/tracing/grafana-tempo.yaml (1 hunks)
• charts/base-cluster/values.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: check licenses
• GitHub Check: Update release-please config file for a possibly new chart
• GitHub Check: lint helm chart (base-cluster)

🔇 Additional comments (2)

charts/base-cluster/templates/monitoring/tracing/grafana-tempo.yaml (1)

26-29: PVC deletion policy: good intent; verify chart and K8s support.

The policy matches the goal (delete on HelmRelease removal; retain on scale-down). Please confirm:

• The chart templates for 1.48.0 actually render spec.persistentVolumeClaimRetentionPolicy from these values; otherwise this is a no-op.
• Cluster K8s version supports StatefulSet persistentVolumeClaimRetentionPolicy (else apply will fail).

Operational note: This is destructive on deletion; consider adding a short release note for awareness.

You can validate post‑reconcile with:

• Check rendered manifest (Flux):
  • kubectl -n monitoring get statefulset -l app.kubernetes.io/name=grafana-tempo-ingester -o yaml | rg -n "persistentVolumeClaimRetentionPolicy|whenDeleted|whenScaled"
• Confirm K8s version (>= version that supports the field):
  • kubectl version --short

charts/base-cluster/values.yaml (1)

114-114: Version bump LGTM; compatibility confirmed. Verified no breaking changes in values schema or defaults from 1.46.0→1.48.0 and support for ingester.persistentVolumeClaimRetentionPolicy (whenDeleted/whenScaled).

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}