feat(base-cluster/cert-manager): enableCertificateOwnerRef

[cwrau]

That way secrets are automatically cleaned up when the corresponding Certificate is deleted

Summary by CodeRabbit

• New Features
  • Enabled certificate owner references in cert-manager deployments.

[coderabbitai]

Walkthrough

The cert-manager HelmRelease manifest in the base-cluster chart was updated to include the enableCertificateOwnerRef: true configuration. This change adds a boolean flag to enable certificate owner references in cert-manager. No other logic or control flow was changed.

Changes

Cohort / File(s)	Change Summary
Cert-Manager HelmRelease Configuration charts/base-cluster/templates/cert-manager/cert-manager.yaml	Added enableCertificateOwnerRef: true to cert-manager values, enabling certificate owner references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

base-cluster

Suggested reviewers

• tasches
• teutonet-bot
• marvinWolff

Poem

A toggle was flipped in the cluster’s domain,
Cert-manager’s flags now dance in the rain.
Owner refs enabled, certificates cheer,
Simpler relations, the purpose is clear.
With YAML so tidy, and settings so neat—
This rabbit approves, with a thump of its feet! 🐇

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/base-cluster/enable-ownerref-for-cert-manager

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This PR enables automatic cleanup of certificate-related secrets in cert-manager by setting the enableCertificateOwnerRef configuration option to true. This ensures that when a Certificate resource is deleted, the corresponding secret containing the certificate data is automatically removed as well.

• Enables enableCertificateOwnerRef feature in cert-manager configuration

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef6382d and 8701217.

📒 Files selected for processing (1)

• charts/base-cluster/templates/cert-manager/cert-manager.yaml (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: in the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for cloudflare prov...

Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1601
File: charts/base-cluster/templates/dns/external-dns.yaml:33-39
Timestamp: 2025-07-24T09:56:41.380Z
Learning: In the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for Cloudflare provider are intentionally hard-coded. Users who need custom secret names should use Helm's `valuesFrom` feature to override values rather than expecting dedicated fields in values.yaml. This design keeps the values.yaml clean while still allowing full customization flexibility.

Applied to files:

• charts/base-cluster/templates/cert-manager/cert-manager.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: lint helm chart (base-cluster)
• GitHub Check: check licenses