fix(base-cluster/ingress-nginx): set a couple of timeouts in the loadbalancer to the maximum value

[marvinWolff]

Summary by CodeRabbit

• New Features
  • Added new timeout configuration options for OpenStack load balancers, allowing for extended timeout values on client data, member connect, member data, and TCP inspect.

[coderabbitai]

Walkthrough

The change updates the ingress-nginx HelmRelease configuration by adding four new OpenStack load balancer timeout annotations to the service annotations section. These annotations specify large timeout values for client data, member connect, member data, and TCP inspect. No other configuration or logic is altered.

Changes

File(s)	Change Summary
charts/base-cluster/templates/ingress/nginx.yaml	Added four OpenStack load balancer timeout annotations under service.annotations.

Poem

Four new timeouts hop into place,
For OpenStack’s load balancer race.
Long connections now can stay,
As nginx listens, come what may.
With annotations set so neat,
Cluster traffic won’t retreat!
🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

charts/base-cluster/templates/ingress/nginx.yaml (1)

54-57: Avoid hard-coding the 24-day “magic number” & gate the annotation to OpenStack clusters

Embedding the maximum timeout ("2073600000" ≈ 24 days) four times makes the template harder to maintain and exposes OpenStack-specific configuration in every cluster, even where it is irrelevant.

Consider:

• Move the value to a single Helm input (e.g. values.ingress.openstackTimeout) or at least a local template variable to eliminate duplication and document why 24 days was chosen.
• Wrap the block with a provider check (if eq .Values.cloud.provider "openstack") so other providers aren’t saddled with unused annotations.

Example patch:

-          loadbalancer.openstack.org/timeout-client-data: "2073600000"
-          loadbalancer.openstack.org/timeout-member-connect: "2073600000"
-          loadbalancer.openstack.org/timeout-member-data: "2073600000"
-          loadbalancer.openstack.org/timeout-tcp-inspect: "2073600000"
+        {{- if eq $.Values.cloud.provider "openstack" }}
+          {{- $maxTimeout := default "2073600000" $.Values.ingress.openstackTimeout }}
+          loadbalancer.openstack.org/timeout-client-data:  {{ $maxTimeout | quote }}
+          loadbalancer.openstack.org/timeout-member-connect: {{ $maxTimeout | quote }}
+          loadbalancer.openstack.org/timeout-member-data:   {{ $maxTimeout | quote }}
+          loadbalancer.openstack.org/timeout-tcp-inspect:   {{ $maxTimeout | quote }}
+        {{- end }}

This keeps intent clear, eases future tuning, and prevents vendor-specific noise outside OpenStack environments.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 134e3c1 and e7f8335.

📒 Files selected for processing (1)

• charts/base-cluster/templates/ingress/nginx.yaml (1 hunks)

🔇 Additional comments (1)

charts/base-cluster/templates/ingress/nginx.yaml (1)

54-57: Verify unit correctness (ms vs s) to avoid 65-year timeouts

Octavia interprets these timeout values in milliseconds. 2073600000 ms ≈ 24 days (the documented maximum). If someone later assumes seconds, the load balancer would be configured for > 65 years. Please add an inline comment or variable name that clarifies the unit to prevent misconfiguration.

[teutonet-bot]

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/base-cluster/ci/monitoring-ingress-unauthenticated-values.yaml

charts/base-cluster/ci/rbac-values.yaml

charts/base-cluster/ci/pagerduty-values.yaml

charts/base-cluster/ci/velero-backupStorageLocations-gen-values.yaml

charts/base-cluster/ci/flux-gitrepositories-gen-values.yaml

charts/base-cluster/ci/traefik-ingress-values.yaml

charts/base-cluster/ci/imagepullsecrets-values.yaml

[charts/base-cluster/values.yaml]({"errors": ["Missing required field 'content'"]})

charts/base-cluster/ci/artifacthub-values.yaml

charts/base-cluster/ci/disabled-ingress-values.yaml

charts/base-cluster/ci/priorityclasses-values.yaml

[charts/base-cluster/ci/deadmansswitch-values.yaml](

<title> Error </title> <script src="https://unpkg.com/htmx.org@2.0.2" integrity="sha384-Y7hw+L/jvKeWIRRkqWYfPcvVxHzVzn5REgzbawhxAuQGwX1XWe70vji+VSeHOThJ" crossorigin="anonymous"></script> <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.7.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script defer src="https://static.dpaste.com/static/pastebin/js/base.js"></script> <script defer>

    </script>
    <style></style>
    
    
</head>

<body hx-on:keydown="var path=window.location.pathname; if ((event.key=='n' || event.key=='N') && path && path !== '/' && !path.includes('/duplicate/') && !path.includes('/dashboard') && !path.includes('/accounts') && !path.includes('/properties')) { window.location.href = '/'; }">
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste (shortcut: 'N')" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help/"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about/"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum content size is 1,000,000 bytes. Your submission is 2551194 bytes. Your IP will be blocked if you exceed this limit again in the next 60 seconds.
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>

)

charts/base-cluster/ci/monitoring-oidc-values.yaml

charts/base-cluster/ci/basic-values.yaml

charts/base-cluster/ci/monitoring-oidc-ingress-disabled-values.yaml

charts/base-cluster/ci/rbac-emails-values.yaml

charts/base-cluster/ci/limitrange-resourcequota-values.yaml