chore(main): [bot] release base-cluster:9.1.1#1647
Merged
Conversation
teutonet-bot
requested review from
a team,
cwrau,
marvinWolff and
tasches
as code owners
WalkthroughThis change increments the version of the base-cluster Helm chart from 9.1.0 to 9.1.1, updates the changelog to document a security-related bug fix for the kdave container, and synchronizes the version in the release manifest. No other modifications or functional changes are present. Changes
Sequence Diagram(s)Not applicable: No new feature or control flow change introduced. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNone identified. Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
cwrau
previously approved these changes
Aug 1, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
charts/base-cluster/CHANGELOG.md (1)
3-9: Short-hash preferred for commit links to stay consistentPrevious entries abbreviate the commit SHA to 7 characters (e.g.
e433c02).
The new line uses the full 40-char hash (431548d0e3d6…), breaking the visual pattern.-* **base-cluster/monitoring:** lock down kdave container ... (431548d0e3d6423e06818f01ac0fd12ca5a3bf86) +* **base-cluster/monitoring:** lock down kdave container ... (431548d)This keeps the CHANGELOG uniform and easier to scan.
(No functional impact, purely cosmetic.)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/release-please/manifest.json(1 hunks)charts/base-cluster/CHANGELOG.md(1 hunks)charts/base-cluster/Chart.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The kubernetes-sigs/metrics-server Helm chart uses `v{{ .Chart.AppVersion }}` as the default image tag when `image.tag` is empty, which provides pinned versioning through the chart's AppVersion rather than using floating tags like "latest".
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1602
File: charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml:38-40
Timestamp: 2025-07-24T09:49:40.961Z
Learning: Official Helm charts like oauth2-proxy manage image versioning automatically through their Chart.yaml appVersion field, making manual tag pinning in consumer values unnecessary and potentially harmful. The chart version itself provides reproducibility by ensuring the correct image tag is used.
📚 Learning: the official kubernetes-sigs/metrics-server helm chart pins the image tag to a specific version in i...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Applied to files:
.github/release-please/manifest.jsoncharts/base-cluster/Chart.yaml
📚 Learning: official helm charts like oauth2-proxy manage image versioning automatically through their chart.yam...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1602
File: charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml:38-40
Timestamp: 2025-07-24T09:49:40.961Z
Learning: Official Helm charts like oauth2-proxy manage image versioning automatically through their Chart.yaml appVersion field, making manual tag pinning in consumer values unnecessary and potentially harmful. The chart version itself provides reproducibility by ensuring the correct image tag is used.
Applied to files:
.github/release-please/manifest.jsoncharts/base-cluster/Chart.yaml
📚 Learning: the kubernetes-sigs/metrics-server helm chart uses `v{{ .chart.appversion }}` as the default image t...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The kubernetes-sigs/metrics-server Helm chart uses `v{{ .Chart.AppVersion }}` as the default image tag when `image.tag` is empty, which provides pinned versioning through the chart's AppVersion rather than using floating tags like "latest".
Applied to files:
.github/release-please/manifest.jsoncharts/base-cluster/Chart.yaml
📚 Learning: in the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for cloudflare prov...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1601
File: charts/base-cluster/templates/dns/external-dns.yaml:33-39
Timestamp: 2025-07-24T09:56:41.380Z
Learning: In the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for Cloudflare provider are intentionally hard-coded. Users who need custom secret names should use Helm's `valuesFrom` feature to override values rather than expecting dedicated fields in values.yaml. This design keeps the values.yaml clean while still allowing full customization flexibility.
Applied to files:
.github/release-please/manifest.jsoncharts/base-cluster/Chart.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Update release-please config file for a possibly new chart
- GitHub Check: update metadata file for release
- GitHub Check: check licenses
- GitHub Check: lint helm chart (base-cluster)
🔇 Additional comments (3)
charts/base-cluster/Chart.yaml (1)
22-22: Chartversionbumped – verifyappVersionThe semantic-version patch bump to
9.1.1is correct.
If anappVersionfield exists later in this file, ensure it’s bumped as well so Helm UIs don’t show mixed versions..github/release-please/manifest.json (1)
1-1: Manifest in sync with chart version
release-pleasemanifest now reflects9.1.1; looks good.charts/base-cluster/CHANGELOG.md (1)
3-9: Content & versioning look goodThe entry correctly bumps to 9.1.1, the date matches the PR, and the single security fix is scoped under “Bug Fixes”. LGTM.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/base-cluster/README.md (1)
249-249: Align bullet-list style with markdownlint expectations.
markdownlintflags the asterisk here because the file (and our lint config) prefers-for unordered lists. Consistency keeps the linter quiet and avoids style noise in future diffs.-* <https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v9.1.1/charts/base-cluster> +- <https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v9.1.1/charts/base-cluster>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
charts/base-cluster/Chart.yaml(1 hunks)charts/base-cluster/README.md(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- charts/base-cluster/Chart.yaml
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The kubernetes-sigs/metrics-server Helm chart uses `v{{ .Chart.AppVersion }}` as the default image tag when `image.tag` is empty, which provides pinned versioning through the chart's AppVersion rather than using floating tags like "latest".
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1602
File: charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml:38-40
Timestamp: 2025-07-24T09:49:40.961Z
Learning: Official Helm charts like oauth2-proxy manage image versioning automatically through their Chart.yaml appVersion field, making manual tag pinning in consumer values unnecessary and potentially harmful. The chart version itself provides reproducibility by ensuring the correct image tag is used.
📚 Learning: official helm charts like oauth2-proxy manage image versioning automatically through their chart.yam...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1602
File: charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml:38-40
Timestamp: 2025-07-24T09:49:40.961Z
Learning: Official Helm charts like oauth2-proxy manage image versioning automatically through their Chart.yaml appVersion field, making manual tag pinning in consumer values unnecessary and potentially harmful. The chart version itself provides reproducibility by ensuring the correct image tag is used.
Applied to files:
charts/base-cluster/README.md
📚 Learning: the kubernetes-sigs/metrics-server helm chart uses `v{{ .chart.appversion }}` as the default image t...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The kubernetes-sigs/metrics-server Helm chart uses `v{{ .Chart.AppVersion }}` as the default image tag when `image.tag` is empty, which provides pinned versioning through the chart's AppVersion rather than using floating tags like "latest".
Applied to files:
charts/base-cluster/README.md
📚 Learning: the official kubernetes-sigs/metrics-server helm chart pins the image tag to a specific version in i...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Applied to files:
charts/base-cluster/README.md
📚 Learning: in the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for cloudflare prov...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1601
File: charts/base-cluster/templates/dns/external-dns.yaml:33-39
Timestamp: 2025-07-24T09:56:41.380Z
Learning: In the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for Cloudflare provider are intentionally hard-coded. Users who need custom secret names should use Helm's `valuesFrom` feature to override values rather than expecting dedicated fields in values.yaml. This design keeps the values.yaml clean while still allowing full customization flexibility.
Applied to files:
charts/base-cluster/README.md
🪛 markdownlint-cli2 (0.17.2)
charts/base-cluster/README.md
249-249: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: check licenses
- GitHub Check: update metadata file for release
- GitHub Check: lint helm chart (base-cluster)
🔇 Additional comments (1)
charts/base-cluster/README.md (1)
3-3: Version badge update looks good.The bump to 9.1.1 in the badge correctly reflects the new chart version.
cwrau
approved these changes
Aug 1, 2025
cwrau
deleted the
release-please--branches--main--components--base-cluster
branch
Contributor
Author
|
🤖 Created releases: 🌻 |
This was referenced Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
9.1.1 (2025-08-01)
Bug Fixes
This PR was generated with Release Please. See documentation.
Summary by CodeRabbit
Bug Fixes
Documentation
Chores