chore(main): [bot] release base-cluster:9.1.0#1628
Conversation
teutonet-bot
requested review from
a team,
cwrau,
marvinWolff and
tasches
as code owners
|
Warning Rate limit exceeded@teutonet-bot has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 51 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThis change updates the base-cluster Helm chart from version 9.0.0 to 9.1.0. It includes a new changelog entry detailing one new feature, several bug fixes, and miscellaneous chores. The version is incremented in both the chart definition and the release manifest. Changes
Sequence Diagram(s)Not applicable—no new features or control flow changes introduced in this PR. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/release-please/manifest.json(1 hunks)charts/base-cluster/CHANGELOG.md(1 hunks)charts/base-cluster/Chart.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: lint helm chart (base-cluster)
- GitHub Check: wait-for-checks
🔇 Additional comments (4)
charts/base-cluster/Chart.yaml (2)
22-22: LGTM on semantic version bumpVersion field correctly moves from 9.0.0 → 9.0.1 and keeps SemVer.
No additional changes required here.
34-34: metrics-server image override may be outdated – please verify upstream chart defaultsThe Chart.yaml override in charts/base-cluster (line 34) still pins
docker.io/bitnami/metrics-server:0.8.0-debian-12-r1, but the 9.0.1 changelog indicates the image was migrated away from Bitnami. If the upstream metrics-server v9.0.1 chart now uses a different image, remove or update this override to keep vulnerability scanners and Artifact Hub accurate.
- charts/base-cluster/Chart.yaml: line 34
.github/release-please/manifest.json (1)
1-1: Manifest bump looks consistentThe manifest entry reflects
9.0.1forcharts/base-cluster; no issues spotted.charts/base-cluster/CHANGELOG.md (1)
3-14: Changelog entry aligns, but consider linking image updatesThe new 9.0.1 section documents the Kyverno fix and metrics-server migration.
Given the discrepancy noted inChart.yamlannotations, ensure the image reference change is actually part of the commit history; if not, update the changelog accordingly to avoid confusion.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/base-cluster/README.md (1)
249-249: Use the repository-wide bullet style to silence markdownlint
The rest of the README uses dash (-) list markers, but this new entry uses an asterisk (*), triggering MD004. Aligning styles keeps the linter quiet and avoids future noise.-* <https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v9.0.1/charts/base-cluster> +- <https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v9.0.1/charts/base-cluster>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
charts/base-cluster/Chart.yaml(2 hunks)charts/base-cluster/README.md(4 hunks)
✅ Files skipped from review due to trivial changes (1)
- charts/base-cluster/Chart.yaml
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
charts/base-cluster/README.md
249-249: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
🔇 Additional comments (2)
charts/base-cluster/README.md (2)
3-3: Version badge correctly bumped to 9.0.1
Consistent with Chart.yaml and CHANGELOG. No further action required.
1754-1757: Documentation wording is clear; consider line-wrapping for readability
The added note about the DynamicResourceAllocation feature gate is helpful and technically accurate. If you touch this section again, consider soft-wrapping long table cells/descriptions (<120 chars) to keep diffs smaller, but no change is strictly required now.Also applies to: 1764-1767
teutonet-bot
force-pushed
the
release-please--branches--main--components--base-cluster
branch
from
cbee140 to
63b9a31
Compare
teutonet-bot
changed the title
teutonet-bot
force-pushed
the
release-please--branches--main--components--base-cluster
branch
3 times, most recently
from
da4f37b to
90b3c6d
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
charts/base-cluster/README.md (4)
247-251: Unify unordered-list marker to silence MD004Static analysis flagged the asterisk list style. Everything else in the README uses dashes (
-). Switching keeps markdown-lint green and gives a uniform look.-* <https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v9.1.0/charts/base-cluster> -* <https://github.com/teutonet/teutonet-helm-charts/tree/main/charts/base-cluster> +- <https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v9.1.0/charts/base-cluster> +- <https://github.com/teutonet/teutonet-helm-charts/tree/main/charts/base-cluster>
449-453: Add a meaningful description forglobal.imageRendererThe new top-level object is introduced with an empty description column (
-). Readers won’t know why or when to set it. Consider replacing the dash with a short sentence, e.g.:Image (repository, tag, digest) of the grafana-image-renderer side-car used by dashboards.
1652-1672:issuerHostmarked Required – verify template usage
issuerHostis now required whileissuerPathis optional. Make sure every template that builds OIDC URLs has been updated from{{ .Values.global.authentication.config.issuerPath }}to the new host/path split, otherwise installs will fail with “missing key” errors.If you need help scanning the templates, let me know.
1771-1777: Wrap bare URLs to appease MD034The two Kubernetes doc links are flagged as bare URLs. Wrap them in angle brackets or link text:
- Limits describes the maximum amount of compute resources allowed. More info: https://kubernetes.io/... + Limits describes the maximum amount of compute resources allowed. + See <https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/> for details.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
charts/base-cluster/Chart.yaml(2 hunks)charts/base-cluster/README.md(61 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- charts/base-cluster/Chart.yaml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The kubernetes-sigs/metrics-server Helm chart uses `v{{ .Chart.AppVersion }}` as the default image tag when `image.tag` is empty, which provides pinned versioning through the chart's AppVersion rather than using floating tags like "latest".
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1602
File: charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml:38-40
Timestamp: 2025-07-24T09:49:40.961Z
Learning: Official Helm charts like oauth2-proxy manage image versioning automatically through their Chart.yaml appVersion field, making manual tag pinning in consumer values unnecessary and potentially harmful. The chart version itself provides reproducibility by ensuring the correct image tag is used.
charts/base-cluster/README.md (5)
Learnt from: cwrau
PR: #1602
File: charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml:38-40
Timestamp: 2025-07-24T09:49:40.961Z
Learning: Official Helm charts like oauth2-proxy manage image versioning automatically through their Chart.yaml appVersion field, making manual tag pinning in consumer values unnecessary and potentially harmful. The chart version itself provides reproducibility by ensuring the correct image tag is used.
Learnt from: cwrau
PR: #1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Learnt from: cwrau
PR: #1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The kubernetes-sigs/metrics-server Helm chart uses v{{ .Chart.AppVersion }} as the default image tag when image.tag is empty, which provides pinned versioning through the chart's AppVersion rather than using floating tags like "latest".
Learnt from: cwrau
PR: #1601
File: charts/base-cluster/templates/dns/external-dns.yaml:33-39
Timestamp: 2025-07-24T09:56:41.380Z
Learning: In the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for Cloudflare provider are intentionally hard-coded. Users who need custom secret names should use Helm's valuesFrom feature to override values rather than expecting dedicated fields in values.yaml. This design keeps the values.yaml clean while still allowing full customization flexibility.
Learnt from: cwrau
PR: #1601
File: charts/base-cluster/templates/dns/external-dns.yaml:30-32
Timestamp: 2025-07-24T09:55:53.655Z
Learning: In charts/base-cluster/templates/dns/external-dns.yaml, the dns.provider field in values.yaml has always been expected to be a map format (e.g., { cloudflare: {} }), never a string format. The template correctly uses {{ .Values.dns.provider | keys | first }} to extract the provider name from the map keys.
🪛 markdownlint-cli2 (0.17.2)
charts/base-cluster/README.md
249-249: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
970-970: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
1038-1038: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
1041-1041: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
1165-1165: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
1175-1175: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
1185-1185: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
1195-1195: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
1226-1226: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
1236-1236: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
1246-1246: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
1256-1256: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
1775-1775: Bare URL used
(MD034, no-bare-urls)
1776-1776: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (1)
charts/base-cluster/README.md (1)
1-4: Ensure version badge & Chart.yaml stay in syncThe README now advertises version 9.1.0. Double-check that
Chart.yaml,appVersion, and the release tag created by Release-Please all carry the exact same version to avoid Helm “version mismatch” warnings at install time.
teutonet-bot
force-pushed
the
release-please--branches--main--components--base-cluster
branch
from
4e8e283 to
5609259
Compare
teutonet-bot
deleted the
release-please--branches--main--components--base-cluster
branch
|
🤖 Created releases: 🌻 |
2 participants
🤖 I have created a release beep boop
9.1.0 (2025-07-31)
Features
Bug Fixes
validationFailureActionsyntax (#1621) (c3f16be)Miscellaneous Chores
This PR was generated with Release Please. See documentation.
Summary by CodeRabbit
New Features
Bug Fixes
validationFailureActionsyntax.Chores
Documentation