Skip to content

fix(base-cluster/monitoring): also create metrics for resources without suspend field#1634

Merged
cwrau merged 1 commit intomainfrom
fix/base-cluster/flux-metrics
Jul 29, 2025
Merged

fix(base-cluster/monitoring): also create metrics for resources without suspend field#1634
cwrau merged 1 commit intomainfrom
fix/base-cluster/flux-metrics

Conversation

@cwrau
Copy link
Copy Markdown
Member

@cwrau cwrau commented Jul 29, 2025

Otherwise there are no metrics which creates an alert for missing metrics

Summary by CodeRabbit

  • New Features
    • Updated monitoring configuration to treat missing values for the "reconcile_suspended_gauge" metric as zero, improving metric accuracy and consistency in dashboards.

…ut suspend field

Otherwise there are no metrics which creates an alert for missing metrics
Copilot AI review requested due to automatic review settings July 29, 2025 10:04
@cwrau cwrau enabled auto-merge July 29, 2025 10:04
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jul 29, 2025

Walkthrough

A new field, "nilIsZero": true, was added to the gauge metric configuration for the reconcile_suspended_gauge metric within the customResourceState section of the kube-prometheus-stack configuration. No other modifications or changes to control flow or public entities were introduced.

Changes

Cohort / File(s) Change Summary
Prometheus Gauge Metric Configuration
charts/base-cluster/templates/monitoring/kube-prometheus-stack/_kube-state-metrics-config.yaml
Added "nilIsZero": true to the reconcile_suspended_gauge metric's gauge configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

base-cluster

Suggested reviewers

  • tasches
  • teutonet-bot
  • marvinWolff

Poem

A metric tweak, a subtle feat,
Where nils now count as zero neat.
Prometheus watches, ever wise,
With gauges clear before its eyes.
A rabbit hops, with metrics new—
Review is quick, the changes few!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ebc2d74 and 6fcd034.

📒 Files selected for processing (1)
  • charts/base-cluster/templates/monitoring/kube-prometheus-stack/_kube-state-metrics-config.yaml (1 hunks)
🔇 Additional comments (1)
charts/base-cluster/templates/monitoring/kube-prometheus-stack/_kube-state-metrics-config.yaml (1)

88-91: Verify kube-state-metrics image tag ≥ v2.7.0

nilIsZero was added in the kube-state-metrics binary after v2.6. Because this chart doesn’t explicitly override the subchart’s image.tag, Helm will default to v{{ .Chart.AppVersion }} from the kube-state-metrics subchart. Please confirm that the pulled chart’s AppVersion (or your override) is at least v2.7.0:

  • If you haven’t set kube-prometheus-stack.kube-state-metrics.image.tag in your top-level values.yaml, inspect the kube-prometheus-stack subchart’s AppVersion to ensure it’s ≥ 2.7.0.
  • If the AppVersion is older, explicitly pin the image in values.yaml:
kube-prometheus-stack:
  kube-state-metrics:
    image:
      tag: v2.7.0
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/base-cluster/flux-metrics

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a monitoring issue by ensuring metrics are generated for Kubernetes resources that don't have a suspend field. The change adds a nilIsZero configuration to the kube-state-metrics custom resource state configuration, which prevents missing metrics that would otherwise trigger alerts.

Key Changes

  • Modified kube-state-metrics configuration to treat nil suspend field values as zero

@cwrau cwrau added this pull request to the merge queue Jul 29, 2025
Merged via the queue into main with commit 964b34c Jul 29, 2025
16 of 27 checks passed
@cwrau cwrau deleted the fix/base-cluster/flux-metrics branch July 29, 2025 10:23
github-merge-queue Bot pushed a commit that referenced this pull request Jul 31, 2025
🤖 I have created a release *beep* *boop*
---


##
[9.1.0](base-cluster-v9.0.0...base-cluster-v9.1.0)
(2025-07-31)


### Features

* **base-cluster:** use new networkPolicy template
([#1414](#1414))
([e433c02](e433c02))


### Bug Fixes

* **base-cluster/kyverno:** migrate to new `validationFailureAction`
syntax
([#1621](#1621))
([c3f16be](c3f16be))
* **base-cluster/monitoring:** also create metrics for resources without
suspend field
([#1634](#1634))
([964b34c](964b34c))
* **base-cluster/monitoring:** oauth-proxy serviceMonitor labels
([#1625](#1625))
([86c1981](86c1981))
* **base-cluster/monitoring:** pin image-renderer version to ensure it's
compatible
([#1631](#1631))
([685592c](685592c))


### Miscellaneous Chores

* **base-cluster/dependencies:** update helm release
kube-prometheus-stack to v75.15.1
([#1610](#1610))
([256cb8e](256cb8e))
* **base-cluster/dependencies:** update helm release loki to v6.33.0
([#1618](#1618))
([7e6a8e8](7e6a8e8))
* **base-cluster/dns:** migrate external-dns away from bitnami
([#1601](#1601))
([7af34d2](7af34d2))
* **base-cluster/monitoring:** adjust metrics syntax
([#1562](#1562))
([ebc2d74](ebc2d74))
* **base-cluster/monitoring:** migrate metrics-server away from bitnami
([#1604](#1604))
([6a755d9](6a755d9))
* **base-cluster:** migrate kubectl image away from bitnami
([#1606](#1606))
([6fe2410](6fe2410))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
  * Introduced a new networkPolicy template in the base-cluster.

* **Bug Fixes**
* Updated kyverno component to use the latest `validationFailureAction`
syntax.
  * Added metrics for resources in monitoring that lack a suspend field.
* Corrected labels in the oauth-proxy serviceMonitor within monitoring.
  * Pinned image-renderer version to ensure compatibility.

* **Chores**
  * Upgraded helm releases for kube-prometheus-stack and loki.
* Migrated external-dns, metrics-server, and kubectl images away from
bitnami.
  * Adjusted metrics syntax in monitoring.

* **Documentation**
  * Added changelog entry for version 9.1.0.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants