Skip to content

chore(base-cluster/monitoring): remove deprecated plugin#1478

Merged
cwrau merged 1 commit intomainfrom
chore/base-cluster/remove-deprecated-grafana-plugin
May 23, 2025
Merged

chore(base-cluster/monitoring): remove deprecated plugin#1478
cwrau merged 1 commit intomainfrom
chore/base-cluster/remove-deprecated-grafana-plugin

Conversation

@cwrau
Copy link
Copy Markdown
Member

@cwrau cwrau commented May 22, 2025

this panel is already included anyways, see
https://grafana.com/grafana/plugins/grafana-piechart-panel

Summary by CodeRabbit

  • Refactor
    • Updated Grafana configuration to only include plugins specified by user settings, removing the default inclusion of the "grafana-piechart-panel" plugin.

Copilot AI review requested due to automatic review settings May 22, 2025 08:45
@cwrau cwrau enabled auto-merge May 22, 2025 08:45
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2025

Walkthrough

The change updates the Grafana configuration template by removing the default inclusion of the "grafana-piechart-panel" plugin. Now, only plugins explicitly listed in the configuration values are included, allowing for more flexible and customizable plugin management.

Changes

File(s) Change Summary
charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml Removed hardcoded "grafana-piechart-panel" plugin; now only includes plugins from configuration.

Poem

In the land of charts and YAML bright,
A pie chart plugin takes its flight.
No longer forced, but called by name,
Only when values say the same.
Grafana hops with lighter load—
Custom plugins now bestowed!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4a41da and 1951a73.

📒 Files selected for processing (1)
  • charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: generateDiffCommentBody
  • GitHub Check: check licenses
  • GitHub Check: lint helm chart (base-cluster)
  • GitHub Check: wait-for-checks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated grafana-piechart-panel plugin configuration from the Grafana config file since it is now included by default.

  • Remove the deprecated plugin entry
  • Clean up the plugins list in the YAML configuration
Comments suppressed due to low confidence (1)

charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml:64

  • The removal of the deprecated grafana-piechart-panel entry is appropriate. Please ensure that no additional configuration dependencies exist for excluding this plugin from the overall plugins list.
-  - grafana-piechart-panel

@teutonet-bot
Copy link
Copy Markdown
Contributor

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/base-cluster/ci/monitoring-ingress-unauthenticated-values.yaml

charts/base-cluster/ci/rbac-values.yaml

charts/base-cluster/ci/pagerduty-values.yaml

charts/base-cluster/ci/velero-backupStorageLocations-gen-values.yaml

charts/base-cluster/ci/flux-gitrepositories-gen-values.yaml

charts/base-cluster/ci/imagepullsecrets-values.yaml

charts/base-cluster/values.yaml

charts/base-cluster/ci/artifacthub-values.yaml

charts/base-cluster/ci/disabled-ingress-values.yaml

charts/base-cluster/ci/priorityclasses-values.yaml

[charts/base-cluster/ci/deadmansswitch-values.yaml](

<title> Error </title> <script src="https://unpkg.com/htmx.org@2.0.2" integrity="sha384-Y7hw+L/jvKeWIRRkqWYfPcvVxHzVzn5REgzbawhxAuQGwX1XWe70vji+VSeHOThJ" crossorigin="anonymous"></script> <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.7.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script> <script>
    </script>
    <style></style>
    
    
</head>

<body hx-on:keydown="var path=window.location.pathname; if ((event.key=='n' || event.key=='N') && path && path !== '/' && !path.includes('/duplicate/') && !path.includes('/dashboard/') && !path.includes('/accounts/') && !path.includes('/properties/')) { window.location.href = '/'; }">
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste (shortcut: 'N')" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help/"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about/"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum content size is 1,000,000 characters. Your submission is 2,541,262. Your IP will be blocked if you exceed this limit again in the next 60 seconds.
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>
)

charts/base-cluster/ci/monitoring-oidc-values.yaml

charts/base-cluster/ci/basic-values.yaml

charts/base-cluster/ci/monitoring-oidc-ingress-disabled-values.yaml

charts/base-cluster/ci/limitrange-resourcequota-values.yaml

@marvinWolff
Copy link
Copy Markdown
Collaborator

Have you checked that this plugin is not used?

@cwrau cwrau added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit ee22df5 May 23, 2025
41 of 42 checks passed
@cwrau cwrau deleted the chore/base-cluster/remove-deprecated-grafana-plugin branch May 23, 2025 08:05
github-merge-queue Bot pushed a commit that referenced this pull request May 27, 2025
🤖 I have created a release *beep* *boop*
---


##
[8.0.0](base-cluster-v7.2.1...base-cluster-v8.0.0)
(2025-05-27)


### ⚠ BREAKING CHANGES

* **base-cluster/ingress:** add option traefik for ingress controller
and make it default
([#1420](#1420))
* **base-cluster/monitoring:** migrate promtail to alloy
([#1347](#1347))

### Features

* **base-cluster/ingress-nginx:** use risk-level Critical when
annotations are enabled
([#1417](#1417))
([a9d8ef2](a9d8ef2))
* **base-cluster/ingress:** add option traefik for ingress controller
and make it default
([#1420](#1420))
([f62b197](f62b197))
* **base-cluster/ingress:** rename oauth-proxies to have a clean name
([#1434](#1434))
([27a28d5](27a28d5))
* **base-cluster/monitoring:** migrate promtail to alloy
([#1347](#1347))
([24db445](24db445))
* **base-cluster/monitoring:** rename alloy to be a generic name
([#1433](#1433))
([3f5826a](3f5826a))


### Bug Fixes

* **base-cluster/cert-manager:** metrics collection
([#1397](#1397))
([71e1189](71e1189))
* **base-cluster/rbac:** *RoleBindings should always be prefixed to
avoid collision
([#1484](#1484))
([75de246](75de246))


### Miscellaneous Chores

* **base-cluster/monitoring:** remove deprecated plugin
([#1478](#1478))
([ee22df5](ee22df5))
* **base-cluster:** formatting
([#1424](#1424))
([853f146](853f146))
* **base-cluster:** pin all versions
([#1447](#1447))
([ec8a430](ec8a430))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Added support for the Traefik ingress controller, now recommended and
available as an alternative to NGINX.
- Updated ingress configuration to use a new provider option, allowing
selection between "nginx", "traefik", or "none".
- Expanded documentation with detailed migration guides and ingress
controller comparisons.

- **Breaking Changes**
- Traefik is now the default ingress controller; configuration for
disabling ingress has changed.
- Monitoring stack migrated from promtail to alloy; Loki deployment
updated and namespace changed.
  - Deprecated properties and configuration options removed or replaced.

- **Bug Fixes**
  - Improved metrics collection in cert-manager.
  - Resolved RBAC role binding name collisions.

- **Chores**
  - Updated container image versions and removed deprecated plugins.
- Reformatted and reorganized chart metadata and documentation for
clarity.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants