feat(base-cluster/monitoring): rename alloy to be a generic name#1433
feat(base-cluster/monitoring): rename alloy to be a generic name#1433
Conversation
WalkthroughThe change updates the Helm chart configuration by renaming the HelmRelease resource. The resource name is changed from "alloy" to "telemetry-collector" in the metadata, and a new field Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
charts/base-cluster/templates/monitoring/alloy.yaml (2)
8-8: Label Consistency Check
The labelapp.kubernetes.io/component: alloystill references "alloy". If the intention is to completely rebrand the resource, consider updating this label for consistency, or confirm that it should remain as a legacy identifier.
12-12: Chart Reference Consistency
The chart specification still references"chart": "alloy"in the inclusion template. Verify if this is intended or if the chart itself should be renamed to reflect the generic change. Consistency here can avoid confusion in release tracking.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
charts/base-cluster/templates/monitoring/alloy.yaml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: generateDiffCommentBody
- GitHub Check: lint helm chart (base-cluster)
- GitHub Check: wait-for-checks
🔇 Additional comments (2)
charts/base-cluster/templates/monitoring/alloy.yaml (2)
5-5: Resource Name Update Verification
The metadata’s resource name has been updated totelemetry-collectoras intended. Please ensure that any downstream dependencies or documentation referencing this HelmRelease are also updated to use the new name.
26-26: Added fullnameOverride Field
IntroducingfullnameOverride: telemetry-collectorundervaluesaligns with the new naming strategy. This helps enforce the Helm release name override, ensuring that templates render as expected.
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
🤖 I have created a release *beep* *boop* --- ## [8.0.0](base-cluster-v7.2.1...base-cluster-v8.0.0) (2025-05-27) ### ⚠ BREAKING CHANGES * **base-cluster/ingress:** add option traefik for ingress controller and make it default ([#1420](#1420)) * **base-cluster/monitoring:** migrate promtail to alloy ([#1347](#1347)) ### Features * **base-cluster/ingress-nginx:** use risk-level Critical when annotations are enabled ([#1417](#1417)) ([a9d8ef2](a9d8ef2)) * **base-cluster/ingress:** add option traefik for ingress controller and make it default ([#1420](#1420)) ([f62b197](f62b197)) * **base-cluster/ingress:** rename oauth-proxies to have a clean name ([#1434](#1434)) ([27a28d5](27a28d5)) * **base-cluster/monitoring:** migrate promtail to alloy ([#1347](#1347)) ([24db445](24db445)) * **base-cluster/monitoring:** rename alloy to be a generic name ([#1433](#1433)) ([3f5826a](3f5826a)) ### Bug Fixes * **base-cluster/cert-manager:** metrics collection ([#1397](#1397)) ([71e1189](71e1189)) * **base-cluster/rbac:** *RoleBindings should always be prefixed to avoid collision ([#1484](#1484)) ([75de246](75de246)) ### Miscellaneous Chores * **base-cluster/monitoring:** remove deprecated plugin ([#1478](#1478)) ([ee22df5](ee22df5)) * **base-cluster:** formatting ([#1424](#1424)) ([853f146](853f146)) * **base-cluster:** pin all versions ([#1447](#1447)) ([ec8a430](ec8a430)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added support for the Traefik ingress controller, now recommended and available as an alternative to NGINX. - Updated ingress configuration to use a new provider option, allowing selection between "nginx", "traefik", or "none". - Expanded documentation with detailed migration guides and ingress controller comparisons. - **Breaking Changes** - Traefik is now the default ingress controller; configuration for disabling ingress has changed. - Monitoring stack migrated from promtail to alloy; Loki deployment updated and namespace changed. - Deprecated properties and configuration options removed or replaced. - **Bug Fixes** - Improved metrics collection in cert-manager. - Resolved RBAC role binding name collisions. - **Chores** - Updated container image versions and removed deprecated plugins. - Reformatted and reorganized chart metadata and documentation for clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Summary by CodeRabbit
The release updates the monitoring configuration to ensure greater consistency and clarity across deployments. End-users will notice a unified naming approach that enhances overall system integration.