Skip to content

QVAC-13614 feat: integrate OCR addon with diagnostics contributor pattern#800

Merged
olyasir merged 6 commits into
mainfrom
feat/QVAC-13614-integrate-ocr-addon-diagnostics-clean
Mar 11, 2026
Merged

QVAC-13614 feat: integrate OCR addon with diagnostics contributor pattern#800
olyasir merged 6 commits into
mainfrom
feat/QVAC-13614-integrate-ocr-addon-diagnostics-clean

Conversation

@olyasir

@olyasir olyasir commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add _packageName, _packageVersion, and _getDiagnosticsJSON() to ONNXOcr class
  • Add @qvac/diagnostics as optional dependency in ocr-onnx/package.json
  • Add unit tests (7 tests, 23 assertions) covering diagnostics fields, JSON serialization, state reflection, and round-trip registration

Changes

packages/ocr-onnx/index.js

packages/ocr-onnx/package.json

  • Added @qvac/diagnostics as optional dependency — zero impact if not installed

packages/ocr-onnx/test/unit/diagnostics.test.js

  • Uses stub TestOCR class to test without native bindings
  • Round-trip test with @qvac/diagnostics skips gracefully when package unavailable

Test plan

  • Unit tests pass locally (npm run test:unit in ocr-onnx)
  • CI sanity-checks pass
  • CI cpp-lint passes
  • All 8 prebuilds pass (linux-x64, linux-arm64, darwin-arm64, win32-x64, android-arm64, ios-arm64, ios-arm64-simulator, ios-x64-simulator)
  • All integration tests pass (linux-x64, linux-arm64, darwin-arm64, win32-x64)
  • iOS E2E passes
  • Android E2E — known flaky, continue-on-error

Depends on: #796 (already merged)
Asana: https://app.asana.com/0/0/1213441152822598

olyasir added 4 commits March 10, 2026 19:12
Wire ocr-onnx as the first addon to use @qvac/diagnostics. Add
_packageName, _packageVersion, and _getDiagnosticsJSON() to ONNXOcr.
Add @qvac/diagnostics as optionalDependency. Add PoC validation unit
tests for the diagnostics integration pattern.
@olyasir olyasir requested review from a team as code owners March 10, 2026 17:19
@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (2/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@olyasir

olyasir commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

/review

@olyasir

olyasir commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

/review

@olyasir olyasir merged commit 5f78a45 into main Mar 11, 2026
13 of 14 checks passed
@olyasir olyasir deleted the feat/QVAC-13614-integrate-ocr-addon-diagnostics-clean branch March 11, 2026 08:41
Proletter pushed a commit that referenced this pull request May 24, 2026
…tern (#800)

* feat: integrate @qvac/diagnostics into ocr-onnx addon

Wire ocr-onnx as the first addon to use @qvac/diagnostics. Add
_packageName, _packageVersion, and _getDiagnosticsJSON() to ONNXOcr.
Add @qvac/diagnostics as optionalDependency. Add PoC validation unit
tests for the diagnostics integration pattern.

* fix: make diagnostics round-trip test skip gracefully when package unavailable

* fix: simplify _getDiagnosticsJSON to pass through all params

* fix: use @qvac/diagnostics package name instead of relative path in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants