QVAC-13614 feat: integrate OCR addon with diagnostics contributor pattern#800
Merged
olyasir merged 6 commits intoMar 11, 2026
Merged
Conversation
Wire ocr-onnx as the first addon to use @qvac/diagnostics. Add _packageName, _packageVersion, and _getDiagnosticsJSON() to ONNXOcr. Add @qvac/diagnostics as optionalDependency. Add PoC validation unit tests for the diagnostics integration pattern.
DmitryMalishev
approved these changes
Mar 10, 2026
Contributor
Tier-based Approval Status |
iancris
approved these changes
Mar 11, 2026
Contributor
Author
|
/review |
gianni-cor
approved these changes
Mar 11, 2026
Contributor
Author
|
/review |
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
…tern (#800) * feat: integrate @qvac/diagnostics into ocr-onnx addon Wire ocr-onnx as the first addon to use @qvac/diagnostics. Add _packageName, _packageVersion, and _getDiagnosticsJSON() to ONNXOcr. Add @qvac/diagnostics as optionalDependency. Add PoC validation unit tests for the diagnostics integration pattern. * fix: make diagnostics round-trip test skip gracefully when package unavailable * fix: simplify _getDiagnosticsJSON to pass through all params * fix: use @qvac/diagnostics package name instead of relative path in test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_packageName,_packageVersion, and_getDiagnosticsJSON()toONNXOcrclass@qvac/diagnosticsas optional dependency inocr-onnx/package.jsonChanges
packages/ocr-onnx/index.jsthis._packageName = '@qvac/ocr-onnx'andthis._packageVersionfrom package.json_getDiagnosticsJSON()method returns{ status, params }as JSON stringnot_loaded→loaded→destroyedload()/destroy()packages/ocr-onnx/package.json@qvac/diagnosticsas optional dependency — zero impact if not installedpackages/ocr-onnx/test/unit/diagnostics.test.jsTestOCRclass to test without native bindings@qvac/diagnosticsskips gracefully when package unavailableTest plan
npm run test:unitin ocr-onnx)Depends on: #796 (already merged)
Asana: https://app.asana.com/0/0/1213441152822598