Skip to content

infra: fix windows bare tooling setup on windows when installing nodejs too (part 1) #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olyasir merged 1 commit into from
May 22, 2026
Merged

infra: fix windows bare tooling setup on windows when installing nodejs too (part 1) #2216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/actions/setup-bare-tooling/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ name: Setup Bare tooling
description: Setup Node and install the global Bare runtime and bare-make tooling used by prebuild workflows.

inputs:
shell_type:
description: "bash | powershell"
required: false
default: bash
node-version:
description: Node version to install
required: false
Expand All @@ -20,5 +24,5 @@ runs:
node-version: ${{ inputs.node-version }}

- name: Install global dependencies
shell: bash
shell: ${{ inputs.shell_type }}
run: npm install -g --force bare-runtime bare-make ${{ inputs.extra-packages }}
2 changes: 2 additions & 0 deletions .github/workflows/cpp-tests-classification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ jobs:

- name: Setup Bare tooling
uses: tetherto/qvac/.github/actions/setup-bare-tooling@926f6f14092fbacaa3606ea475457fddf37d9838
with:
shell_type: ${{ matrix.platform == 'win32' && 'powershell' || 'bash' }}

- name: Setup Apple Clang
if: ${{ matrix.platform == 'darwin' }}
Expand Down
12 changes: 2 additions & 10 deletions .github/workflows/integration-test-classification-ggml.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,6 @@ jobs:
arch: x64

steps:
- name: Setup Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # 6.3.0
with:
node-version: lts/*

- name: Windows — enable git long paths
if: ${{ matrix.platform == 'win32' }}
shell: bash
run: git config --system core.longpaths true

- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # 6.0.2
with:
Expand All @@ -80,6 +70,8 @@ jobs:

- name: Setup Bare runtime
uses: tetherto/qvac/.github/actions/setup-bare-tooling@926f6f14092fbacaa3606ea475457fddf37d9838
with:
shell_type: ${{ matrix.platform == 'win32' && 'powershell' || 'bash' }}

- name: Install npm dependencies
working-directory: ${{ env.PKG_DIR }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/reusable-prebuilds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ jobs:

- name: Setup Bare tooling
uses: tetherto/qvac/.github/actions/setup-bare-tooling@926f6f14092fbacaa3606ea475457fddf37d9838
with:
shell_type: ${{ matrix.platform == 'win32' && 'powershell' || 'bash' }}

- name: Setup Apple Clang
uses: tetherto/qvac/.github/actions/setup-apple-clang@1d9b2165867d03c6edd675e402ee101a5d48a6d8
Expand Down
Loading