Skip to content

infra: fix windows bare tooling setup on windows when installing nodejs too (part 1)#2216

Merged
olyasir merged 1 commit into
mainfrom
tmp-fix-windows-bare-tooling-setup
May 22, 2026
Merged

infra: fix windows bare tooling setup on windows when installing nodejs too (part 1)#2216
olyasir merged 1 commit into
mainfrom
tmp-fix-windows-bare-tooling-setup

Conversation

@tamer-hassan-tether

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Fixes exit code 127 (command not found) when npm install bare tooling runs after nodejs setup step in the bare tooling setup composite action

How does it solve it?

ensures windows uses powershell rather than bash. all else, use bash by default.

a followup PR will be proposed to use the hash of the updated composite action (setup-bare-tooling)

Breaking changes

none

@tamer-hassan-tether tamer-hassan-tether requested review from a team as code owners May 22, 2026 21:13
@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@olyasir olyasir merged commit 1210623 into main May 22, 2026
41 of 43 checks passed
@olyasir olyasir deleted the tmp-fix-windows-bare-tooling-setup branch May 22, 2026 21:20
Proletter pushed a commit that referenced this pull request May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants