Skip to content

chore: regenerate diffusion-cpp NOTICE#1955

Merged
gianni-cor merged 5 commits into
mainfrom
chore/regenerate-diffusion-cpp-notice
May 11, 2026
Merged

chore: regenerate diffusion-cpp NOTICE#1955
gianni-cor merged 5 commits into
mainfrom
chore/regenerate-diffusion-cpp-notice

Conversation

@gianni-cor

Copy link
Copy Markdown
Contributor

Summary

Regenerate packages/diffusion-cpp/NOTICE using .cursor/skills/notice-generate after the merge of #1901, which shipped the new standalone EsrganUpscaler API but did not include a NOTICE refresh.

Why

The NOTICE on main is structurally stale relative to the canonical output of the notice-generate skill — it uses an older verbose per-package format rather than the current sorted SPDX-grouped layout. No required attributions are added or removed; this is a deterministic re-emission.

What changed

  • packages/diffusion-cpp/NOTICE: +21 / -203 (net -182 lines, 358 → 155 lines after format change)

Coverage produced by the skill (scan types: models-engine, js, cpp for @qvac/diffusion-cpp):

Section Count Notes
Models 8 FLUX.2-klein-4B + Qwen3 + RealESRGAN ×3 + SD2.1 + SDXL
JavaScript dependencies 26 Resolved transitively via npm install --production --ignore-scripts
C++ dependencies 5 ggml, picojson, stable-diffusion-cpp, stb, libc++ (LLVM runtime)

The python scan type is correctly skipped — diffusion-cpp has no Python code (verified by find packages/diffusion-cpp -name "requirements*.txt" -o -name "pyproject.toml" -o -name "*.py" → 0 matches).

How to verify

source .env  # GH_TOKEN + NPM_TOKEN
node .cursor/skills/notice-generate/scripts/generate-notice.js diffusion-cpp
git diff packages/diffusion-cpp/NOTICE   # should be empty

The skill is deterministic — re-running on identical input produces identical output, so any future regeneration on the same dep tree will be a no-op.

Test plan

  • Skill ran cleanly (1 informational warning about libc++ triplet detection, expected).
  • No new direct npm or vcpkg deps introduced; deltas are pure reformatting + scoped to format-driven sort/group changes.
  • Reviewer skim of the diff to confirm no attribution was dropped.

Made with Cursor

Run notice-generate skill to refresh the NOTICE file format and pick
up post-1901 attributions in the new sorted SPDX-grouped layout.

No required attributions are added or removed; this is a deterministic
re-emission of the existing model / JS / C++ dependency lists in the
canonical format produced by .cursor/skills/notice-generate.

Co-authored-by: Cursor <cursoragent@cursor.com>
Adds the upstream repository + copyright block already present in
packages/registry-server/NOTICE for the Real-ESRGAN BSD-3-Clause models
distributed by @qvac/diffusion-cpp.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Comment thread packages/diffusion-cpp/NOTICE
@gianni-cor

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

github-actions Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@gianni-cor

Copy link
Copy Markdown
Contributor Author

/review

@gianni-cor gianni-cor merged commit 3bdeb9f into main May 11, 2026
14 of 15 checks passed
@gianni-cor gianni-cor deleted the chore/regenerate-diffusion-cpp-notice branch May 11, 2026 15:24
Proletter pushed a commit that referenced this pull request May 24, 2026
* chore: regenerate diffusion-cpp NOTICE

Run notice-generate skill to refresh the NOTICE file format and pick
up post-1901 attributions in the new sorted SPDX-grouped layout.

No required attributions are added or removed; this is a deterministic
re-emission of the existing model / JS / C++ dependency lists in the
canonical format produced by .cursor/skills/notice-generate.

Co-authored-by: Cursor <cursoragent@cursor.com>

* chore: add RealESRGAN copyright attribution to diffusion-cpp NOTICE

Adds the upstream repository + copyright block already present in
packages/registry-server/NOTICE for the Real-ESRGAN BSD-3-Clause models
distributed by @qvac/diffusion-cpp.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Update images license

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants